Intervals On Bar Not Updating

[zmanowar]

From #3:

It was successfully logged, but it was my first random to spawn since the conversion so that seems like a likely explanation. Though it seems like the overlay debug tick counter did update, just not the countdown/intervals. I took this picture at 11:00, which is 47 minutes since the previous random. If you convert the ticks to minutes, you get a little less than 46 minutes (I spent a small amount of time logged out/hopping worlds testing things), so that seemed to update just fine.

I'll update my comment to say what happens when the next one spawns.

Originally posted by @samszotkowski in #3 (comment)

[zmanowar]

Creating a new issue here to track this -- the bar most likely reset but the total "Intervals" counter did not. I think I see the issue. Intervals is based on current logged-in time -- may need a secondary counter for last spawn.

Technically the panel calls getIntervalsSinceLastRandom, which calculates the number of intervals as a basis of logged in time.

I think modifying getCurrentSessionNumIntervals to reference the last spawned time in conjunction with the login time might be the fix. Will probably end up writing a test to check a few things.

[samszotkowski]

(screenshot taken at 12:07)
Most things (overlay tick counter, sidebar countdown and green bar) seem to be working properly after my next random spawned, but the interval counter gets updated to show how many intervals since login, and delta event time recorded in the log shows the time since login (it says 1:04:59, which is not possible considering the random spawned at about 1:05:00 since login) instead of the time since last random.

[zmanowar]

Most likely solved in 39c6d6e. The entire tracking for secondsSinceLastRandomEvent was janky.

Intervals may still be broken, going to investigate a bit further.