Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Use SparseSets for ActionState Component and Benchmarks #29

Closed
chrisburnor opened this issue Nov 29, 2021 · 2 comments
Closed
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@chrisburnor
Copy link

Bevy 0.5 introduced SparseSet Storage (see Release Notes) for components with high add/remove volume to avoid . If I'm understanding, from my (somewhat cursory) reading of the code that ActionState probably falls into this category and would probably generate a performance boost if added.

I might be very wrong on the way that ActionState is implemented, but it would be very good to add some benchmarks for performance validation.

@zkat
Copy link
Owner

zkat commented Nov 29, 2021

maybe? I'd take a PR for this :)

@chrisburnor
Copy link
Author

I'll, see what I can do, though likely the higher priority for me would be #28. If I can figure out the internals enough for that one, I should have enough to implement this one too.

@zkat zkat added enhancement New feature or request help wanted Extra attention is needed labels Jan 8, 2022
@zkat zkat closed this as completed in f938482 Jan 9, 2022
zkat added a commit that referenced this issue Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants