New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WeightedProduct always returns zero #103

Open

ItsDoot opened this issue Aug 15, 2024 · 0 comments

ItsDoot commented Aug 15, 2024

This should have an initial value of one, not zero:

big-brain/src/measures.rs

Lines 33 to 39 in db1509d

    
           impl Measure for WeightedProduct { 
        
               fn calculate(&self, scores: Vec<(&Score, f32)>) -> f32 { 
        
                   scores 
        
                       .iter() 
        
                       .fold(0f32, |acc, (score, weight)| acc * score.0 * weight) 
        
               } 
        
           }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment