Icon Consistency

[jmacato]

Since we have adopted a Visual Studio-style User Interface, it is imperative that we have to sort out our Icon Design Language to be more inline with the guidelines as shown here:
https://docs.microsoft.com/en-us/visualstudio/extensibility/ux-guidelines/images-and-icons-for-visual-studio?view=vs-2019

[molnard]

If we are planning to use design guidelines: #6
We will have icons like this: https://material.io/resources/icons/?style=baseline

[jmacato]

For reference: Comparisons of VS's handling of Solution Explorer Icons

Light Theme, 9pt font size:

Dark Theme, 9pt:

Light Theme, 15pt:

Dark Theme, 15pt:

Observations:

1. They dont scale the icons with the font, we could do better than that since we use vectorized icons everywhere anyway.

2. The grayscale palette described in the VS Icon design is inverted when it switches to dark mode. Accent colors are ignored.

[molnard]

I like it and also that the user will have an option to use light mode.

[jmacato]

AvaloniaUI/Avalonia#3655 prevents us from doing dynamic color change for icons and other controls that are declared inside styles

Seems to be fixed at Avalonia master branch. Though the fix is not backportable so the color/theme change feature may wait until the next major release...

[jmacato]

Addressed by WalletWasabi/WalletWasabi#3267 :)