Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error generating JSON via graph command #492

Closed
2 tasks done
WhyNotHugo opened this issue Jan 19, 2025 · 4 comments
Closed
2 tasks done

Error generating JSON via graph command #492

WhyNotHugo opened this issue Jan 19, 2025 · 4 comments

Comments

@WhyNotHugo
Copy link
Contributor

Check if applicable

  • I have searched the existing issues (required)
  • I'm willing to help fix the problem and contribute a pull request

Describe the bug

Previously discussed in #48

Generating a JSON graph fail with:

not a serializable argument for {{json}}: json: error calling MarshalJSON for type *core.lazyStringer: invalid character 't' after top-level value

How to reproduce?

I can reproduce this with a single note: qm4h.md (I picked on at random, it seems that most of my notes fail).

Run command zk graph --format json > /dev/null.

zk configuration

I created a new notebook with a minimal config:


[note]
template = "default.md"
[extra]
[format.markdown]
hashtags = false
colon-tags = false
multiword-tags = false
[tool]
[lsp]
[lsp.diagnostics]
dead-link = "error"
[lsp.completion]
[filter]
[alias]

Environment

zk-0.14.1-r3
Linux 6.12.8-0-edge x86_64 Linux
@WhyNotHugo
Copy link
Contributor Author

I can't repro with latest main, so it looks like this may have been fixed.

@WhyNotHugo
Copy link
Contributor Author

Bisected this; issue was fixed in 4a51e39.

I'd appreciate a new release which includes this fix.

@WhyNotHugo
Copy link
Contributor Author

See also: #389

@tjex
Copy link
Member

tjex commented Jan 26, 2025

Yep, it was fixed in #440. As for a release, there's still some bug fixes for the 0.14.2 milestone.

But they're seemingly heavy ones (lsp / completion). I think enough has been done to merit a release in the current state to 0.14.2, and move the other bugs to 0.14.3 milestone.

I'll look into it. We've just implemented a new CI and release automation, so the next release is going to need more attention perhaps. Bare with me.

@tjex tjex closed this as completed Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants