Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up test_cluster_handler_registry test #265

Open
TheJulianJES opened this issue Oct 26, 2024 · 0 comments
Open

Split up test_cluster_handler_registry test #265

TheJulianJES opened this issue Oct 26, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@TheJulianJES
Copy link
Contributor

Initially, the test_cluster_handlers.py:test_cluster_handler_registry test didn't do a whole lot.
With home-assistant/core@37707ed#diff-7126848f7becb03b017f77521684b3372d7a95f1859f6e9763493af52de8a780, it was expanded with quirk IDs and also checks a lot more now, including making sure the test can find all custom clusters defined in zha-quirks if they're used in a cluster handler in ZHA. This is done by looping over the (v1) quirks device registry and looking at the signature/replacement of all quirks.

We might want to split up that test in a quirk id related test and one that verifies the clusters used for cluster handlers are defined somewhere.

Related PRs:

@TheJulianJES TheJulianJES added the enhancement New feature or request label Oct 26, 2024
@TheJulianJES TheJulianJES changed the title Split out test_cluster_handler_registry Split up test_cluster_handler_registry test Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant