Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model_id (model identifier) in addition to existing model to the Zigbee DeviceInfo class? #216

Open
Hedda opened this issue Sep 30, 2024 · 1 comment

Comments

@Hedda
Copy link

Hedda commented Sep 30, 2024

The upcoming Home Assistant 2024.10 (now in Beta) will add support for adding Model IDs to devices and are calling for contributions to add model IDs to more integrations, as mention under the "Other noteworthy changes" section in the release notes for that new version:

In June, we added support for adding Model IDs to devices. This release has lots of integrations that add them, including Matter, Plugwise, Wallbox, and Govee. We are calling for contributions to add model IDs to more integrations! Maybe a cool suggestion for an Hacktoberfest contribution!

Please consider if can how could add model_id (model identifier) to the Zigbee DeviceInfo class to enable returning both model_id and model as device description for device to allow identify the device model id separate from model, which can then be exposed separatly in the ZHA integration for Home Assistant as this is meant to be a unified way to display a device model identifier in the Home Assistant frontend.

https://developers.home-assistant.io/blog/2024/07/16/device-info-model-id/

Starting from 2024.8, you can now add a model identifier to the DeviceInfo class. This identifier can be used to identify the device model in integrations and the frontend.

For example, the Philips Hue ambiance spot was previously listed as "Hue ambiance spot (LTG002)". This can now be split up, where the model is "Hue ambiance spot" and the model_id is "LTG002".

UPDATE: For reference, looks like puddly begun adding prerequisite in zigpy to allow renaming devices with quirks, see:

Note! zigbee-herdsman-converters for Zigbee2MQTT does something similar to separate Model (Brand SKU) from Zigbee ID.

I imagine that this feature could for example be useful in a ZHA quirk when dealing with white-label products that have been rebranded and given a different product article-numbers/SKU from what the OEM/ODM manufacturer has written into the device firmware. For example white-label devices manufactured by Tuya being sold under different brands and product article-numbers/SKU than what is written as the Zigbee signature in the firmware.

PS: Noted that specific device in the example given by joostlek is a Zigbee device but assume he tested with the Hue integration?

@Hedda
Copy link
Author

Hedda commented Oct 31, 2024

Kind of related to #283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant