Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing light color during an effect causes mismatched state #210

Open
TheJulianJES opened this issue Sep 24, 2024 · 0 comments
Open

Changing light color during an effect causes mismatched state #210

TheJulianJES opened this issue Sep 24, 2024 · 0 comments
Labels
bug Confirmed bug

Comments

@TheJulianJES
Copy link
Contributor

Currently, when any light attribute is changed (brightness, color, temperature), an active colorloop effect is turned off.
(Do we even want to keep that behavior?)

However, when changing the light color, we first send the color command to the light and only turn off the effect afterwards. This will cause the light to miss the color command and cause mismatched state in HA.
The color command needs to be sent a second time at the moment.

We likely should turn off the effect first in the turn_on method, then send the color commands.

(noticed whilst testing #99)

@TheJulianJES TheJulianJES added the bug Confirmed bug label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

1 participant