Enable warning as error (apache#4451)

* Engineering system enhencement

Enable warning as error
Enable Profiler code into build
Speed up build a bit

* Fix warning in scala package

Author: howard0su

Makefile

@@ -200,8 +200,7 @@ endif
 
 build/src/%.o: src/%.cc
 	@mkdir -p $(@D)
-	$(CXX) -std=c++11 $(CFLAGS) -MM -MT build/src/$*.o $< >build/src/$*.d
-	$(CXX) -std=c++11 -c $(CFLAGS) -c $< -o $@
+	$(CXX) -std=c++11 -c $(CFLAGS) -MMD -c $< -o $@
 
 build/src/%_gpu.o: src/%.cu
 	@mkdir -p $(@D)
@@ -217,8 +216,7 @@ build/plugin/%_gpu.o: plugin/%.cu
 
 build/plugin/%.o: plugin/%.cc
 	@mkdir -p $(@D)
-	$(CXX) -std=c++11 $(CFLAGS) -MM -MT build/plugin/$*.o $< >build/plugin/$*.d
-	$(CXX) -std=c++11 -c $(CFLAGS) -c $< -o $@
+	$(CXX) -std=c++11 -c $(CFLAGS) -MMD -c $< -o $@
 
 %_gpu.o: %.cu
 	@mkdir -p $(@D)
@@ -227,8 +225,7 @@ build/plugin/%.o: plugin/%.cc
 
 %.o: %.cc
 	@mkdir -p $(@D)
-	$(CXX) -std=c++11 $(CFLAGS) -Isrc/operator -MM -MT $*.o $< >$*.d
-	$(CXX) -std=c++11 -c $(CFLAGS) -Isrc/operator -c $< -o $@
+	$(CXX) -std=c++11 -c $(CFLAGS) -MMD -Isrc/operator -c $< -o $@
 
 # NOTE: to statically link libmxnet.a we need the option
 # --Wl,--whole-archive -lmxnet --Wl,--no-whole-archive

appveyor.yml

@@ -52,11 +52,11 @@ before_build:
 
         set OpenCV_DIR=%APPVEYOR_BUILD_FOLDER%/%MXNET_OPENCV_DIR%/build
 
-        cmake .. -DOPENCV_DIR=%OpenCV_DIR% -DUSE_CUDA=0 -DUSE_CUDNN=0 -DUSE_NVRTC=0 -DUSE_OPENCV=1 -DUSE_OPENMP=1 -DUSE_BLAS=open -DUSE_DIST_KVSTORE=0 -G "Visual Studio 12 2013 Win64"
+        cmake .. -DOPENCV_DIR=%OpenCV_DIR% -DUSE_PROFILER=1 -DUSE_CUDA=0 -DUSE_CUDNN=0 -DUSE_NVRTC=0 -DUSE_OPENCV=1 -DUSE_OPENMP=1 -DUSE_BLAS=open -DUSE_DIST_KVSTORE=0 -G "Visual Studio 12 2013 Win64"
 
 build_script:
     - cmd: >-
-        msbuild mxnet.sln /t:Rebuild /p:Configuration=Release;Platform=x64
+        msbuild mxnet.sln /t:Rebuild /p:Configuration=Release;Platform=x64 /m
         
 test_script:
     - cmd: >-

scala-package/native/src/main/native/ml_dmlc_mxnet_native_c_api.cc

@@ -223,7 +223,7 @@ JNIEXPORT jint JNICALL Java_ml_dmlc_mxnet_LibInfo_mxImperativeInvoke
     jclass listClass = env->FindClass("scala/collection/mutable/ArrayBuffer");
     jmethodID listAppend = env->GetMethodID(listClass, "$plus$eq",
         "(Ljava/lang/Object;)Lscala/collection/mutable/ArrayBuffer;");
-    for (size_t i = 0; i < numOutputs; ++i) {
+    for (int i = 0; i < numOutputs; ++i) {
       env->CallObjectMethod(outputs, listAppend,
                             env->NewObject(longCls, longConst,
                             reinterpret_cast<uint64_t>(cOutputs[i])));
@@ -1328,7 +1328,7 @@ JNIEXPORT jint JNICALL Java_ml_dmlc_mxnet_LibInfo_mxSymbolInferType
 
   // release allocated memory
   if (jkeys != NULL) {
-    for (size_t i = 0; i < numArgs; i++) {
+    for (int i = 0; i < numArgs; i++) {
       jstring jkey = reinterpret_cast<jstring>(env->GetObjectArrayElement(jkeys, i));
       env->ReleaseStringUTFChars(jkey, keys[i]);
       env->DeleteLocalRef(jkey);
@@ -1397,7 +1397,7 @@ JNIEXPORT jint JNICALL Java_ml_dmlc_mxnet_LibInfo_mxSymbolInferShape
   const char **keys = NULL;
   if (jkeys != NULL) {
     keys = new const char *[jnumArgs];
-    for (size_t i = 0; i < jnumArgs; i++) {
+    for (int i = 0; i < jnumArgs; i++) {
       jstring jkey = (jstring) env->GetObjectArrayElement(jkeys, i);
       const char *key = env->GetStringUTFChars(jkey, 0);
       keys[i] = key;
@@ -1667,15 +1667,15 @@ JNIEXPORT jint JNICALL Java_ml_dmlc_mxnet_LibInfo_mxRtcCreate
   char *name = const_cast<char *>(env->GetStringUTFChars(jname, 0));
   int num_input = env->GetArrayLength(jinputNames);
   char **inputNames = new char *[num_input];
-  for (size_t i = 0; i < num_input; i++) {
+  for (int i = 0; i < num_input; i++) {
     jstring jinname = reinterpret_cast<jstring>(env->GetObjectArrayElement(jinputNames, i));
     char *inname = const_cast<char *>(env->GetStringUTFChars(jinname, 0));
     inputNames[i] = inname;
     env->DeleteLocalRef(jinname);
   }
   int num_output = env->GetArrayLength(joutputNames);
   char **outputNames = new char *[num_output];
-  for (size_t i = 0; i < num_output; i++) {
+  for (int i = 0; i < num_output; i++) {
     jstring joutname = reinterpret_cast<jstring>(env->GetObjectArrayElement(joutputNames, i));
     char *outname = const_cast<char *>(env->GetStringUTFChars(joutname, 0));
     outputNames[i] = outname;
@@ -1700,13 +1700,13 @@ JNIEXPORT jint JNICALL Java_ml_dmlc_mxnet_LibInfo_mxRtcCreate
   env->ReleaseStringUTFChars(jkernel, kernel);
   env->ReleaseLongArrayElements(jinputs, inputs, 0);
   env->ReleaseLongArrayElements(joutputs, outputs, 0);
-  for (size_t i = 0; i < num_input; i++) {
+  for (int i = 0; i < num_input; i++) {
     jstring jinname = reinterpret_cast<jstring>(env->GetObjectArrayElement(jinputNames, i));
     env->ReleaseStringUTFChars(jinname, inputNames[i]);
     env->DeleteLocalRef(jinname);
   }
   delete[] inputNames;
-  for (size_t i = 0; i < num_output; i++) {
+  for (int i = 0; i < num_output; i++) {
     jstring joutname = reinterpret_cast<jstring>(env->GetObjectArrayElement(joutputNames, i));
     env->ReleaseStringUTFChars(joutname, outputNames[i]);
     env->DeleteLocalRef(joutname);

tests/jenkins/run_test.sh

@@ -3,6 +3,8 @@ cp make/config.mk .
 echo "USE_CUDA=1" >> config.mk
 echo "USE_CUDA_PATH=/usr/local/cuda" >> config.mk
 echo "USE_CUDNN=1" >> config.mk
+echo "USE_PROFILER=1" >> config.mk
+echo "DEV=1" >> config.mk
 make -j$(nproc) || exit -1
 
 echo "BUILD lint"