Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The CT serialization is slow #269

Open
YakBizzarro opened this issue Oct 19, 2023 · 1 comment
Open

The CT serialization is slow #269

YakBizzarro opened this issue Oct 19, 2023 · 1 comment
Assignees
@markheik

Comments

@YakBizzarro
Copy link
Collaborator

Description

The CommanTable serialization is too slow, it takes few tens of milliseconds even for trivial tables

How to reproduce

Use the attached script ct_performances.zip

Environment info

  • Python version: 3.11.5
  • zhinst-toolkit version: main
  • LabOne version: not relevant (no instrument connection)
  • zhinst version: not relevant (no instrument connection)

Device/system information (if applicable)

Windows 10 22H2

Additional information
@markheik markheik mentioned this issue Oct 19, 2023
Closed
4 tasks
@markheik markheik self-assigned this Oct 19, 2023
@markheik
Copy link
Collaborator

That you for the issue. That is indeed true. This will be addressed in #270

markheik added a commit that referenced this issue Oct 20, 2023
@markheik
Fix performance issue when command table active validation is off (#269)
44ab2c0 
* Do not validate command table in as_dict() when active validation is off
@markheik markheik mentioned this issue Oct 20, 2023
Merged
4 tasks
markheik added a commit that referenced this issue Nov 2, 2023
@markheik
Improve CommandTable performance (#269)
d281fb1 
* Remove all validation when 'CommandTable.active_validation' is disabled

* Remove unnecessary deepcopy of table index schemas to improve performance
markheik added a commit that referenced this issue Nov 2, 2023
@markheik
Fix performance issue when command table active validation is off (#269)
4c95859 
* Do not validate command table in as_dict() when active validation is off
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markheik markheik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@YakBizzarro @markheik