Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema provides wrong default value type on boolean values #240

Open
TowardtheStars opened this issue Mar 31, 2023 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@TowardtheStars
Copy link

Description

In src/zhinst/toolkit/resources/ct_schema_hdawg.json, all boolean value entries with default values are give a string default value, such as "false", which quotation marks should not be there. It is not checked if this is also present on other JSON schema files.

How to reproduce

Environment info

  • Python version:
  • zhinst-toolkit version:
  • LabOne version:
  • zhinst version:

Device/system information (if applicable)

Additional information

@tobiasah
Copy link
Member

@TowardtheStars Thanks for raising this issue

I agree that this is a bug, the default value should be a boolean value, not a string.

The command table comes directly from the firmware of the device (dev8123/awgs/n/commandtable/schema). The hard-coded ones are just for legacy, since the device only exposes them since LabOne 22.08.

In any case, we should fix both, and I will forward this issue to our hardware team so that they can fix the one on the device for the next release (end of June).

@tobiasah tobiasah self-assigned this Mar 31, 2023
@tobiasah tobiasah added the bug Something isn't working label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants