Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Pulse sheet simulator should take amplitude increment into account #59

Open
2 tasks
GlaserN opened this issue Nov 30, 2023 · 1 comment
Open
2 tasks
Labels
enhancement New feature or request jira Sync the issue to ZI LabOneQ internal issue tracker.

Comments

@GlaserN
Copy link

GlaserN commented Nov 30, 2023

Describe the bug
For an experiment scaling the amplitude using real-time loops, the command table will use the increment amplitude argument.

In the interactive_psv simulation, however, the pulse will only be scaled to the value, which is supposed to be incremented instead of steadily increasing.

Here is a compiled_experiment, corresponding to a rabi, with increasing amplitude of the drive pulse.
amplitude_increment.json

Versions used:

  • laboneq: 2.20
  • zhinst-core
  • others

Context

  • Do you know a workaround for the issue? If yes, please provide a short description.
  • Does the issue block your experiments?
@QuantumClemens QuantumClemens added the jira Sync the issue to ZI LabOneQ internal issue tracker. label Jan 3, 2024
@QuantumClemens QuantumClemens added the enhancement New feature or request label Feb 14, 2024
@QuantumClemens
Copy link
Collaborator

@GlaserN we diagnosed the root cause of this issue, it is because the OutputSimulator be default does only analyze part of the sequencer code and not the full sequence, and therefore is not aware of the status of any increments.
We may adapt this in the future, but it may require a larger rework of the OutputSimulator.

@QuantumClemens QuantumClemens changed the title [BUG] - Pulse sheet simulator does not take amplitude increment into account [FEATURE] - Pulse sheet simulator should take amplitude increment into account Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jira Sync the issue to ZI LabOneQ internal issue tracker.
Projects
None yet
Development

No branches or pull requests

2 participants