fix: remove shell: for linker opts

Author: aminya

CMakeLists.txt

@@ -92,17 +92,17 @@ if(ZMQ_WASM OR CMAKE_SYSTEM_NAME STREQUAL "Emscripten")
   add_link_options("--export-table")
 
   # Add WebAssembly-specific exports for napi-wasm
-  add_link_options("SHELL:-s EXPORTED_FUNCTIONS=['_malloc','_free','napi_wasm_malloc','napi_register_module_v1']")
-  add_link_options("SHELL:-s EXPORTED_RUNTIME_METHODS=['ccall','cwrap']")
-  add_link_options("SHELL:-s ALLOW_MEMORY_GROWTH=1")
-  add_link_options("SHELL:-s MODULARIZE=1")
-  add_link_options("SHELL:-s EXPORT_NAME='createModule'")
-  add_link_options("SHELL:-s ENVIRONMENT='web,worker'")
+  add_link_options("-s EXPORTED_FUNCTIONS=['_malloc','_free','napi_wasm_malloc','napi_register_module_v1']")
+  add_link_options("-s EXPORTED_RUNTIME_METHODS=['ccall','cwrap']")
+  add_link_options("-s ALLOW_MEMORY_GROWTH=1")
+  add_link_options("-s MODULARIZE=1")
+  add_link_options("-s EXPORT_NAME='createModule'")
+  add_link_options("-s ENVIRONMENT='web,worker'")
   add_link_options("--no-entry")
-  add_link_options("SHELL:-Wl,--strip-all")
+  add_link_options("-Wl,--strip-all")
 
   # Allow undefined symbols on Linux for runtime loading
-  add_link_options("SHELL:-Wl,--unresolved-symbols=ignore-all")
+  add_link_options("-Wl,--unresolved-symbols=ignore-all")
 endif()
 
 # Set MacOS deployment target

browser/index.js

@@ -1,13 +1,11 @@
 import {Environment, napi} from "napi-wasm"
 
 async function main() {
-  const response = await fetch("./addon.wasm")
-  const bytes = await response.arrayBuffer()
   const {instance} = await WebAssembly.instantiate(
-    bytes,
+    fetch("./addon.wasm"),
     {
       env: napi,
-    },
+    }
   )
 
   // Create an environment.

src/wasm.cc

@@ -3,7 +3,10 @@
 #include <cstdint>
 #include <cstdlib>
 
-extern "C" uint8_t* napi_wasm_malloc(size_t size) {
+// export visibility
+#define EXPORT_VISIBILITY __attribute__((visibility("default")))
+
+extern "C" EXPORT_VISIBILITY uint8_t* napi_wasm_malloc(size_t size) {
     const size_t align = alignof(size_t);
 
     if (size > 0) {