-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
在Consumer 里面有个方法叫startProducers,感觉有点怪 #12
Comments
嗯嗯,这个名字确实容易跟kafka的冲突,在queue内部,拿的叫producer, 消费的叫consumer |
嗯,看的时候是很奇怪。如果想适配其他 queue,建议至少在这儿加个注释说明一下 |
我们也确实实现了好几个不同的queue |
我刚细看了下和其他 queue 没有耦合,因为另一个dq并没有需要内部先 producer再 consumer
这名字实在太奇怪了,看的时候总得在脑子转个几圈。 |
https://github.com/tal-tech/go-queue/blob/3c97bd42eb20ac0356338e10f3fdf47d3746506b/kq/queue.go#L158
上面这个函数,我理解的是这是 Consumer 从Kafka取数据的啊,为啥起名 startProducers。是我哪理解有问题吗?
The text was updated successfully, but these errors were encountered: