-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish ui for dialogues #20
Comments
@aadityaforwork a good starting point. I thought more of something like this Where the name tag is a bit floating above the content box What do you think? |
I was thinking that in an instance where two or more people are involved in the conversation then updating it inside the content would be much more simplistic and better-looking , but sure we can try it placing above the content box as well I am sure it would add some uniqueness! |
Would be great @aadityaforwork . |
@aadityaforwork just let me know when your PR is ready. |
I tried this the problem is that it looks clean inside a single container whereas when we put the character name in a floating box above the content box it seems messy also does not align with the background! |
@aadityaforwork it is okay for me as long as the name is configurable and clearly visible that it is the name and not the conversation text 🙌🏻 |
then I feel the current UI looks configurable and good to go , also PR is ready too. |
The current dialogue UI style is pretty simple.
Although it looks okay-ish there is room for improvement.
For example, there is no name tag on the dialogue about who is actually talking currently.
The dialogue box is written in html and css filled with javascript.
You can (and you should) stick to vanilla html and css to design and style the dialogue box.
You can find the current setup in index.html. It would be also nice to seperate the css from the html file.
The text was updated successfully, but these errors were encountered: