Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish ui for dialogues #20

Closed
r4pt0s opened this issue Sep 30, 2024 · 8 comments · Fixed by #43
Closed

Polish ui for dialogues #20

r4pt0s opened this issue Sep 30, 2024 · 8 comments · Fixed by #43
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest label for 2024

Comments

@r4pt0s
Copy link
Collaborator

r4pt0s commented Sep 30, 2024

The current dialogue UI style is pretty simple.
Although it looks okay-ish there is room for improvement.

For example, there is no name tag on the dialogue about who is actually talking currently.
The dialogue box is written in html and css filled with javascript.

You can (and you should) stick to vanilla html and css to design and style the dialogue box.

You can find the current setup in index.html. It would be also nice to seperate the css from the html file.

@r4pt0s r4pt0s added good first issue Good for newcomers hacktoberfest Hacktoberfest label for 2024 labels Sep 30, 2024
@aadityaforwork
Copy link
Member

aadityaforwork commented Oct 1, 2024

image

Hello I have updated the dialogue box with it's UI as well as the character name is dynamically getting updated does this look good to proceed with or any further changes are there to be done?

@r4pt0s
Copy link
Collaborator Author

r4pt0s commented Oct 1, 2024

@aadityaforwork a good starting point. I thought more of something like this

Where the name tag is a bit floating above the content box

What do you think?

@aadityaforwork
Copy link
Member

@aadityaforwork a good starting point. I thought more of something like this

Where the name tag is a bit floating above the content box

What do you think?

I was thinking that in an instance where two or more people are involved in the conversation then updating it inside the content would be much more simplistic and better-looking , but sure we can try it placing above the content box as well I am sure it would add some uniqueness!

@r4pt0s
Copy link
Collaborator Author

r4pt0s commented Oct 1, 2024

Would be great @aadityaforwork .
You already prepared it by passing in the name as I saw.

@r4pt0s
Copy link
Collaborator Author

r4pt0s commented Oct 1, 2024

@aadityaforwork just let me know when your PR is ready.

@r4pt0s r4pt0s linked a pull request Oct 1, 2024 that will close this issue
@aadityaforwork
Copy link
Member

Would be great @aadityaforwork . You already prepared it by passing in the name as I saw.

I tried this the problem is that it looks clean inside a single container whereas when we put the character name in a floating box above the content box it seems messy also does not align with the background!
My opinion is that let us keep it in a single container at least for now would love to hear your opinion about it.

@r4pt0s
Copy link
Collaborator Author

r4pt0s commented Oct 1, 2024

@aadityaforwork it is okay for me as long as the name is configurable and clearly visible that it is the name and not the conversation text 🙌🏻

@aadityaforwork
Copy link
Member

@aadityaforwork it is okay for me as long as the name is configurable and clearly visible that it is the name and not the conversation text 🙌🏻

then I feel the current UI looks configurable and good to go , also PR is ready too.

@r4pt0s r4pt0s closed this as completed in #43 Oct 2, 2024
@r4pt0s r4pt0s closed this as completed in c629609 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest label for 2024
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants