NXP driver: lptmr: add alarm and guard period API functions. #93302
+135
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
dbaluta,
decsny,
dleach02,
manuargue,
mmahadevan108 and
nordic-krch
Holt-Sun
force-pushed
the
enable-lptmr-alarm-and-guard-period-api-gap-feature
branch
from
86d9932 to
08f6036
Compare
Add alarm APIs: set_alarm, cancel_alarm Add guard period APIs: set_guard_period Signed-off-by: Holt Sun <[email protected]>
Holt-Sun
force-pushed
the
enable-lptmr-alarm-and-guard-period-api-gap-feature
branch
from
08f6036 to
c1525d6
Compare
|
manuargue
reviewed
Jul 18, 2025
| data->alarm_callback = alarm_cfg->callback; | ||
| data->alarm_user_data = alarm_cfg->user_data; | ||
|
|
||
| current = LPTMR_GetCurrentTimerCount(config->base); |
There was a problem hiding this comment.
are you using the same counter register for both top callback and alarms? both APIs can be used simultaneously, so I don't think that's a good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add alarm APIs: set_alarm, cancel_alarm
Add guard period APIs: set_guard_period