fix(RepositoryProxy::find()): allow not entity object in (#441)

Author: nikophil

src/RepositoryProxy.php

@@ -16,6 +16,7 @@
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\EntityRepository;
 use Doctrine\ORM\Mapping\ClassMetadata as ORMClassMetadata;
+use Doctrine\ORM\Mapping\MappingException as ORMMappingException;
 use Doctrine\Persistence\Mapping\MappingException;
 use Doctrine\Persistence\ObjectManager;
 use Doctrine\Persistence\ObjectRepository;
@@ -332,7 +333,7 @@ public function find($criteria)
 
             try {
                 $metadataForAttribute = $this->getObjectManager()->getClassMetadata($attributeValue::class);
-            } catch (MappingException) {
+            } catch (MappingException|ORMMappingException) {
                 $normalizedCriteria[$attributeName] = $attributeValue;
 
                 continue;

tests/Fixtures/Factories/EntityWithEnumFactory.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace Zenstruck\Foundry\Tests\Fixtures\Factories;
+
+use Zenstruck\Foundry\ModelFactory;
+use Zenstruck\Foundry\Proxy;
+use Zenstruck\Foundry\Tests\Fixtures\PHP81\EntityWithEnum;
+use Zenstruck\Foundry\Tests\Fixtures\PHP81\SomeEnum;
+
+final class EntityWithEnumFactory extends ModelFactory
+{
+    protected function getDefaults(): array
+    {
+        return [
+            'enum' => self::faker()->randomElement(SomeEnum::cases()),
+        ];
+    }
+
+    protected static function getClass(): string
+    {
+        return EntityWithEnum::class;
+    }
+}

tests/Functional/ORMModelFactoryTest.php

@@ -18,13 +18,15 @@
 use Zenstruck\Foundry\Tests\Fixtures\Factories\CategoryFactory;
 use Zenstruck\Foundry\Tests\Fixtures\Factories\CommentFactory;
 use Zenstruck\Foundry\Tests\Fixtures\Factories\ContactFactory;
+use Zenstruck\Foundry\Tests\Fixtures\Factories\EntityWithEnumFactory;
 use Zenstruck\Foundry\Tests\Fixtures\Factories\PostFactory;
 use Zenstruck\Foundry\Tests\Fixtures\Factories\PostFactoryWithInvalidInitialize;
 use Zenstruck\Foundry\Tests\Fixtures\Factories\PostFactoryWithNullInitialize;
 use Zenstruck\Foundry\Tests\Fixtures\Factories\PostFactoryWithValidInitialize;
 use Zenstruck\Foundry\Tests\Fixtures\Factories\SpecificPostFactory;
 use Zenstruck\Foundry\Tests\Fixtures\Factories\TagFactory;
 use Zenstruck\Foundry\Tests\Fixtures\Factories\UserFactory;
+use Zenstruck\Foundry\Tests\Fixtures\PHP81\SomeEnum;
 
 /**
  * @author Kevin Bond <[email protected]>
@@ -605,6 +607,21 @@ public function can_find_or_create_from_proxy_of_object(): void
         self::assertSame($comment->object(), $comment2->object());
     }
 
+    /**
+     * @test
+     * @requires PHP 8.1
+     */
+    public function can_find_or_create_entity_with_enum(): void
+    {
+        $entityWithEnum = EntityWithEnumFactory::findOrCreate($attributes = ['enum' => SomeEnum::VALUE]);
+        EntityWithEnumFactory::assert()->count(1);
+
+        $entityWithEnum2 = EntityWithEnumFactory::findOrCreate($attributes);
+        EntityWithEnumFactory::assert()->count(1);
+
+        self::assertSame($entityWithEnum->object(), $entityWithEnum2->object());
+    }
+
     protected function categoryClass(): string
     {
         return Category::class;