Skip to content

Commit d4e9f31

Browse files
authored
chore: addressing a few PR comments (#446)
1 parent d73c49e commit d4e9f31

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

packages/orm/src/client/contract.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@ export enum TransactionIsolationLevel {
6161
* ZenStack client interface.
6262
*/
6363
export type ClientContract<Schema extends SchemaDef, Options extends ClientOptions<Schema> = ClientOptions<Schema>> = {
64+
/**
65+
* The schema definition.
66+
*/
6467
readonly $schema: Schema;
6568

6669
/**

packages/orm/src/utils/schema-utils.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ export class MatchingExpressionVisitor extends ExpressionVisitor {
8181
}
8282

8383
find(expr: Expression) {
84+
this.found = false;
8485
this.visit(expr);
8586
return this.found;
8687
}

packages/plugins/policy/src/expression-evaluator.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ export class ExpressionEvaluator {
106106
invariant(op === '?' || op === '!' || op === '^', 'expected "?" or "!" or "^" operator');
107107

108108
const left = this.evaluate(expr.left, context);
109-
if (!left) {
109+
if (left === null || left === undefined) {
110110
return null;
111111
}
112112

0 commit comments

Comments
 (0)