Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Input Fallback Value is not merged on Input::merge() #35

Open
Maks3w opened this issue Aug 22, 2015 · 4 comments
Open

Input Fallback Value is not merged on Input::merge() #35

Maks3w opened this issue Aug 22, 2015 · 4 comments
Labels
Milestone

Comments

@Maks3w
Copy link
Member

Maks3w commented Aug 22, 2015

I think the fallback value should be replaced when merge is done.

@Maks3w Maks3w added this to the 3.0.0 milestone Aug 22, 2015
@svycka
Copy link
Contributor

svycka commented Aug 24, 2015

I think this is bug not a BC break. I don't think someone is relying on current behavior. But yes also it can be BC break, but very unlikely. This is not documented, no tests.. so I think we don't need to wait till 3.0

@zluiten
Copy link
Contributor

zluiten commented Oct 2, 2015

Imho the intended behavior of merge is to also take care of the fallback value. Therefore this qualifies as a bugfix. I really would like to see this fixed asap.

        if ($input instanceof Input && $input->hasFallback()) {
            $this->setFallbackValue($input->getFallbackValue());
        }

ping @Maks3w

@Maks3w
Copy link
Member Author

Maks3w commented Oct 2, 2015

Fallback feature and merge method exists since a long time and nobody appreciate this before. My conclusion any change in the current behavior introduces a BC break.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-inputfilter; a new issue has been opened at laminas/laminas-inputfilter#12.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants