Skip to content
This repository has been archived by the owner on May 1, 2019. It is now read-only.

Changing the current DB structure #496

Open
ins0 opened this issue Sep 14, 2015 · 5 comments
Open

Changing the current DB structure #496

ins0 opened this issue Sep 14, 2015 · 5 comments

Comments

@ins0
Copy link
Contributor

ins0 commented Sep 14, 2015

I would like to suggest and create a PR with a new DB structure.

The current design isn't nice at all and cause trouble along the way. The modules table isn't well normalized and cause trouble when it comes to "which user uploaded a module" - user repo? company repo? or when a user is changing his github name (not possible currently). On the other side i would like to prepare the site to support different modules from ZF2 and upcoming ZF3.

I will upload the suggested db image today when i'm back home.

So in the meantime i would like to get some feedback if you think this is a good or bad idea and if we should switch with this change to a ORM (doctrine).

// edit
i didn't make it yesterday because i was busy assembling my new barbecue grill 🍖 🍖 - so i hacked this layout together - not optmimal and missing some stuff but you can see where this ship is heading towards.

db

/cc @Ocramius @localheinz @GeeH @adamlundrigan @gianarb

@gianarb
Copy link
Contributor

gianarb commented Sep 14, 2015

Hi @ins0
This proposal sounds good.. This is a strong feature :)

If we would implement doctrine we can use all other tools (migrations, fixtures) to increase our workflow

@ins0
Copy link
Contributor Author

ins0 commented Sep 15, 2015

True @gianarb - i think we already tried to implement migrations but i'm not quite sure. I added a first suggestion for the db.

I think it would be a good way if we also save the required zf version for a module, so as a main feature this would sorting search results by required zf2 version easy?! But not sure if this could be added later because we can't get this information easy from allready registered modules.

@localheinz
Copy link
Member

@gianarb @ins0

I'd second the use of Doctrine, and I'm happy to help!

@localheinz
Copy link
Member

@gianarb @ins0

Here's probably how I would do this, as it's a bit of work:

  1. switch to using doctrine/orm in the first place
  2. start using doctrine/migrations
  3. make changes to the schema

What do you think? All at once, that's too much - and there's probably hardly anyone willing to code review that. Let's take small steps!

@ins0 ins0 mentioned this issue Sep 19, 2015
8 tasks
@gianarb
Copy link
Contributor

gianarb commented Oct 19, 2015

@ins0 now we have migrations :P Can we apply this change in your opinion?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants