Skip to content
This repository has been archived by the owner on May 1, 2019. It is now read-only.

Why can't display my module #202

Open
dudapiotr opened this issue Sep 24, 2014 · 6 comments
Open

Why can't display my module #202

dudapiotr opened this issue Sep 24, 2014 · 6 comments

Comments

@dudapiotr
Copy link

Hi,
I try to publish my new module but I can see either in modules nor in my organization...
I've forked from organization to my profile and have the same.

Base module -
https://github.com/HyPhers/visio-crud-zf2

Forked module
https://github.com/dudapiotr/visio-crud-zf2

Could anyone tell me what am I doing wrong?

@bacinsky
Copy link

Same here

@localheinz
Copy link
Member

@dudapiotr

If the module is a fork, it can't be added, and here's why:

if ($repository->fork || !$repository->permissions->push) {
    throw new Exception\UnexpectedValueException(
        'You have no permission to add this module. The reason might be that you are ' .
        'neither the owner nor a collaborator of this repository.',
        Http\Response::STATUS_CODE_403
    );
}

See ZfModule\Controller\IndexController::addAction().

@localheinz
Copy link
Member

I'm not sure why that decision was made, but I have no objections to discussing it.

However, it's not a bug, it's a feature.

@gianarb
Copy link
Contributor

gianarb commented Feb 24, 2015

In my opinion this is a good feature.. Only the owner can load your module into the site.
@dudapiotr why do you not load this module from HyPhers org?

@GeeH
Copy link
Contributor

GeeH commented Mar 5, 2015

Why are we not allowing forks to be added? Can someone explain in short words to me? Is it just because I could fork a repo and add it as my own? If this is the case then we need a "report module" mechanism.

There are genuine use cases where I can fork from another repo and modify heavily with attribution in place and want to submit my fork as a module. Leaving it as a fork allows my users to see where the project has come from and is an integral part of OS community, and disallowing forks to be added is wrong in my opinion.

@localheinz
Copy link
Member

@GeeH

I think it would be great to show forks!

How about this:

Original and fork are registered

  • when rendering the a registered and forked module, display that it is a fork of the original module
  • when rendering the original module, display a list of registered forks

Fork is registered, original is not

  • when rendering a registered fork, display that it is a fork, but that the original module is not registered

What do you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants