Merge pull request #3916 from zendesk/grosser/multi

remove multibyte patches, we do not need those larger indices

Author: grosser

.github/workflows/actions.yml

@@ -51,11 +51,11 @@ jobs:
         include:
         - name: test mysql w/o plugins
           run: |
-            export PLUGINS='' DATABASE_URL=mysql2://[email protected]/samson_test?reconnect=true BUNDLE_WITHOUT=postgres:sqlite USE_UTF8MB4=1 SILENCE_MIGRATIONS=1
+            export PLUGINS='' DATABASE_URL=mysql2://[email protected]/samson_test?reconnect=true BUNDLE_WITHOUT=postgres:sqlite SILENCE_MIGRATIONS=1
             bundle exec rake db:create test:migrate_without_plugins
         - name: test mysql
           run: |
-            export DATABASE_URL=mysql2://[email protected]/samson_test?reconnect=true BUNDLE_WITHOUT=postgres:sqlite USE_UTF8MB4=1 SILENCE_MIGRATIONS=1
+            export DATABASE_URL=mysql2://[email protected]/samson_test?reconnect=true BUNDLE_WITHOUT=postgres:sqlite SILENCE_MIGRATIONS=1
             bundle exec rake db:create db:migrate default
         - name: test postgres
           run: |

config/initializers/mysql_utf8_mb4.rb

@@ -41,16 +41,6 @@ def assert_content(files)
     File.read('Gemfile.lock').wont_include 'rails-assets-bootstrap '
   end
 
-  if ENV['USE_UTF8MB4'] && ActiveRecord::Base.connection.adapter_name =~ /mysql/i
-    it "uses the right row format in mysql" do
-      status = ActiveRecord::Base.connection.execute('show table status').to_a
-      refute_empty status
-      status.each do |table|
-        table[3].must_equal "Dynamic", "#{table[0]} is not Dynamic"
-      end
-    end
-  end
-
   it "does not have public actions on base controller" do
     found = ApplicationController.action_methods.to_a
     found.reject! { |a| a =~ /^(_conditional_callback_around_|_callback_before_)/ }