Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header navbar colours #1259

Open
simon1066 opened this issue May 25, 2024 · 2 comments
Open

Header navbar colours #1259

simon1066 opened this issue May 25, 2024 · 2 comments

Comments

@simon1066
Copy link
Contributor

simon1066 commented May 25, 2024

I didn't do a great job of colour-coordinating the /user and /dev navbar background colours in PR #1258. As it stands only some pages have the correct colour.

There are, I believe three types of pages -

  • dev
  • user
  • codepage

I now know how to set the dev and user pages to the correct colour (by editing the relevent .html file in /layouts). The problem is codepage page types occur in both /user and /dev, so I don't believe it is possible to fully colour-coordinate all pages.

Two solutions:

  1. Abandon the idea of having different colour navbars and choose a single colour for all by redefining $primary.
  2. Have different colours for the user & dev page types and a third colour for codepage page types.

Something to think about.

@scottcwilson
Copy link
Contributor

It looks good - let's leave it for now.

@scottcwilson
Copy link
Contributor

To be clear: I would like to fix this issue at some point, but we have made a ton of changes in the last couple of weeks, it might be good to let it simmer for a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants