Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Selection in Vim Visual Line Mode Has Incorrect Range #26325

Open
rien7 opened this issue Mar 8, 2025 · 2 comments
Open

Search Selection in Vim Visual Line Mode Has Incorrect Range #26325

rien7 opened this issue Mar 8, 2025 · 2 comments

Comments

@rien7
Copy link
Contributor

rien7 commented Mar 8, 2025

Summary

Search Selection in Vim Visual Line Mode Has Incorrect Range

Steps to trigger the problem:

  1. Open vim mode
  2. Move cursor in the middle of a sentence
  3. Toggle vim visual line mode
  4. Select some lines
  5. Move the last line cursor in the middle of a sentence
  6. Open search panel
  7. Enable search selection
  8. search something

Actual Behavior:
The match items before the first line cursor and after the last line cursor are not matched

Expected Behavior:
All match items in from line and to line should be match

May be similar to #25132

Zed Version and System Specs

Zed: v0.177.5 (Zed Preview)
OS: macOS 15.2.0
Memory: 16 GiB
Architecture: aarch64

@rien7
Copy link
Contributor Author

rien7 commented Mar 8, 2025

Image

  1. At the first line, my cursor is on 3
  2. Change mode to vim visual line
  3. Move down to the last line, the cursor is on 6

@rien7
Copy link
Contributor Author

rien7 commented Mar 9, 2025

It seems that we need a adjust_anchor_ranges in selections_collection.rs to used in toggle_filtered_search_ranges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant