Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited read-only file can be closed in tab panel #26216

Open
bigspawn opened this issue Mar 6, 2025 · 3 comments
Open

Edited read-only file can be closed in tab panel #26216

bigspawn opened this issue Mar 6, 2025 · 3 comments
Labels
needs-repro Needs reproduction steps / someone to reproduce

Comments

@bigspawn
Copy link

bigspawn commented Mar 6, 2025

Summary

It is impossible to close a read-only file in the tab panel after edit and trying to save it.

A read-only file cannot be closed in the tab panel after it has been edited and an attempt to save it has been made. After closing the dialog window, the file remains in the panel and cannot be closed by any of the following methods:
• By clicking the close button (✖) on the tab
• By pressing the Cmd + W shortcut
• By right-clicking the tab and selecting Close

Restarting the editor does not resolve the issue either.

Steps to trigger the problem:

> touch test.txt
> chmod 550 test.txt
> zed test.txt
  • edit file
  • save it
  • ok with popup
  • try to close file tab

Actual Behavior:

Tab doesn't close.

Expected Behavior:

Tab closes.

Zed Version and System Specs

Zed: v0.176.2 (Zed)
OS: macOS 15.3.1
Memory: 16 GiB
Architecture: aarch64

@notpeter
Copy link
Member

notpeter commented Mar 6, 2025

I cannot reproduce (tried with the same v0.176.2 stable you are running).
Am I now following your steps correctly?

Screen.Recording.2025-03-06.at.14.01.13.mov

@notpeter notpeter added the needs-repro Needs reproduction steps / someone to reproduce label Mar 6, 2025
@bigspawn
Copy link
Author

bigspawn commented Mar 6, 2025

Looks like the same steps.

Screen.Recording.2025-03-06.at.22.14.30.mov

@bigspawn
Copy link
Author

bigspawn commented Mar 6, 2025

I tried restarting the computer, and this behavior persists on it. However, on another computer, I was unable to reproduce it while performing the same steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-repro Needs reproduction steps / someone to reproduce
Projects
None yet
Development

No branches or pull requests

2 participants