Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gruvbox or Ayu themes missing syntax defs found in One theme #26206

Open
edwloef opened this issue Mar 6, 2025 · 3 comments
Open

Gruvbox or Ayu themes missing syntax defs found in One theme #26206

edwloef opened this issue Mar 6, 2025 · 3 comments
Labels
design papercut Small visual defect theme Feedback for theme configuration, accessibility, visual issues, etc

Comments

@edwloef
Copy link

edwloef commented Mar 6, 2025

Summary

cc: #26124 (comment)

Many themes don't have a color for variable.special defined, leading to self not being colored specially in rust projects, despite it being a reserved keyword. I encountered this using Gruvbox Dark, however it seems to not be the only affected theme.

Image

Zed Version and System Specs

Zed: v0.176.2 (Zed)
OS: Linux Wayland arch unknown
Memory: 15.4 GiB
Architecture: x86_64
GPU: Intel(R) Iris(R) Xe Graphics (RPL-P) || Intel open-source Mesa driver || Mesa 24.3.4-arch1.1

@notpeter notpeter changed the title Gruvbox Dark doesn't specify color for special variables variable.special Not defined for Gruvbox or Ayu themes Mar 6, 2025
@notpeter notpeter changed the title variable.special Not defined for Gruvbox or Ayu themes Gruvbox or Ayu themes missing syntax defs found in One theme Mar 6, 2025
@notpeter notpeter added theme Feedback for theme configuration, accessibility, visual issues, etc reproducible Verified steps to reproduce included design papercut Small visual defect and removed reproducible Verified steps to reproduce included labels Mar 6, 2025
@notpeter
Copy link
Member

notpeter commented Mar 6, 2025

I can reproduce. Looks like the One themes has variable.special but gruvbox and ayu themes are missing them.

"variable.special": {
"color": "#bf956aff",
"font_style": null,
"font_weight": null
},

We should probably add a test to ensure that all the built-in themes support the same syntaxes so this can't happen in the future.

@AaronFeickert
Copy link
Contributor

@edwloef: Unrelated to the issue itself, what font setting are you using? It's quite nice!

@edwloef
Copy link
Author

edwloef commented Mar 8, 2025

@edwloef: Unrelated to the issue itself, what font setting are you using? It's quite nice!

I'm using Cascadia Mono :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design papercut Small visual defect theme Feedback for theme configuration, accessibility, visual issues, etc
Projects
None yet
Development

No branches or pull requests

3 participants