Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline git blame author (you logic) #10557

Closed
1 task done
henrikruscon opened this issue Apr 15, 2024 · 9 comments
Closed
1 task done

Inline git blame author (you logic) #10557

henrikruscon opened this issue Apr 15, 2024 · 9 comments
Labels
enhancement [core label] git blame git Git integration feedback

Comments

@henrikruscon
Copy link

Check for existing issues

  • Completed

Describe the feature

Would be neat if the newly merged inline git blame could show "You" instead of your username if it is in fact you that is to blame. Just easier/faster to recognise at glance.

If applicable, add mockups / screenshots to help present your vision of the feature

CleanShot 2024-04-15 at 16 00 07@2x

@social-anthrax
Copy link

I'd personally be hesitant to do this, it's just a matter of time before someone would change their username to "you" to try and hide a commit. If this was togglable or had some visual difference from other usernames I'd be all for it.

@jansol
Copy link
Contributor

jansol commented Apr 15, 2024

I think there are some plans to add avatars, so one would have to change both their committer name and github avatar to impersonate someone.

But there definitely could be some additional highlight, maybe with the background color?

@henrikruscon
Copy link
Author

Not really sure what's to gain from hiding your commit from inline code, you can simply hover the git blame and you will get all the details if it's really important in a very particular case. This is just a quality of life improvement. This is a none issue.

@Calinou
Copy link

Calinou commented Jul 16, 2024

One downside of showing "You" is that screenshots of the editor become less contextually relevant, so maybe it should just be highlighted in a different color but without changing the displayed name.

It's like having "x hours ago" in a screenshot with no date information 🙂

@HarshNarayanJha
Copy link
Contributor

What about showing You in brackets? Like Git Name (You)

@social-anthrax
Copy link

I honestly think that this change would be more work than it's worth, as I hope most users know what name they're committing with. If this feature were to go ahead then the proposal by @HarshNarayanJha is something that I personally like.

@HarshNarayanJha
Copy link
Contributor

HarshNarayanJha commented Nov 15, 2024

I could take this up

@HarshNarayanJha
Copy link
Contributor

HarshNarayanJha commented Nov 24, 2024

Okay so what about adding a config option to either show

  1. Author
  2. Author with You
  3. just You

@mikayla-maki
Copy link
Contributor

I don't think we're interested in adding this feature, as it seems to add unnecessary complexity.

@mikayla-maki mikayla-maki closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] git blame git Git integration feedback
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants