-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline git blame author (you logic) #10557
Comments
I'd personally be hesitant to do this, it's just a matter of time before someone would change their username to "you" to try and hide a commit. If this was togglable or had some visual difference from other usernames I'd be all for it. |
I think there are some plans to add avatars, so one would have to change both their committer name and github avatar to impersonate someone. But there definitely could be some additional highlight, maybe with the background color? |
Not really sure what's to gain from hiding your commit from inline code, you can simply hover the git blame and you will get all the details if it's really important in a very particular case. This is just a quality of life improvement. This is a none issue. |
One downside of showing "You" is that screenshots of the editor become less contextually relevant, so maybe it should just be highlighted in a different color but without changing the displayed name. It's like having "x hours ago" in a screenshot with no date information 🙂 |
What about showing You in brackets? Like |
I honestly think that this change would be more work than it's worth, as I hope most users know what name they're committing with. If this feature were to go ahead then the proposal by @HarshNarayanJha is something that I personally like. |
I could take this up |
Okay so what about adding a config option to either show
|
I don't think we're interested in adding this feature, as it seems to add unnecessary complexity. |
Check for existing issues
Describe the feature
Would be neat if the newly merged inline git blame could show "You" instead of your username if it is in fact you that is to blame. Just easier/faster to recognise at glance.
If applicable, add mockups / screenshots to help present your vision of the feature
The text was updated successfully, but these errors were encountered: