Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Picks wrong atuin binary #659

Open
1 task done
jankatins opened this issue Jun 13, 2024 · 1 comment
Open
1 task done

[bug]: Picks wrong atuin binary #659

jankatins opened this issue Jun 13, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jankatins
Copy link
Contributor

jankatins commented Jun 13, 2024

What happened?

I want to install atuin via zinit

zinit default-ice --quiet as'null' from"gh-r" lbin'!' lucid nocompile completions
zinit mv""atuin*/atuin -> atuin"" lbin"!atuin -> atuin" \
     atclone'./atuin init zsh --disable-up-arrow >> zhook.zsh && ./atuin gen-completions --shell zsh > _atuin' atpull'%atclone' \
     src="zhook.zsh" wait'0b' lucid  \
     atload'ZSH_AUTOSUGGEST_STRATEGY=(atuin);_zsh_autosuggest_strategy_atuin() { typeset -g suggestion; suggestion="$(atuin search --limit 1 --search-mode prefix --cmd-only "$1")"; }' for \
   @atuinsh/atuin

This recipe, on my mac x86 laptop, downloads a *-update file instead of the correct atuin*.tar.gz file from the current release: https://github.com/atuinsh/atuin/releases/tag/v18.3.0:

λ  exec zsh

==> Downloading atuinsh/atuin
==> Requesting atuin-x86_64-apple-darwin-update
######################################################################################################################################################################################################################################################### 100.0%
[ziextract] Successfully extracted and assigned +x chmod to the file: atuin-x86_64-apple-darwin-update.
atuin-x86_64-apple-darwin-update -> atuin
error: unexpected argument 'init' found

Usage: atuin [OPTIONS]

For more information, try '--help'.
Warning: ∞zinit-atclone-hook hook returned with 2
==> linkbin: Created atuin soft link & set +x on the atuin binary

Thankfully, an additional bpick"atuin-*.tar.gz" fixed it.

Steps to reproduce

  1. Execute above recipe
  2. Notice the wrongly downloaded file

Operating System & Version

OS: darwin21.3.0 | Vendor: apple | Machine: x86_64 | CPU: x86_64 | Processor: i386 | Hardware: x86_64

Zsh version

zsh 5.9 (x86_64-apple-darwin21.3.0)

Terminal emulator

wezterm

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jankatins jankatins added the bug Something isn't working label Jun 13, 2024
@vladdoster
Copy link
Member

@jankatins, This is an edge-case where I can't think of a fix that would improve odds of correct binary selection.

FWIW, bpick ice can be reduced to a*z.

Screenshot 2024-06-13 at 22 46 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants