correct way to use fzf binary, key-bindings and completion with zinit

[francois-pasquier]

For the moment, I managed to get it working with this snippet:

zi ice wait lucid from"gh-r" as"program" mv"fzf* -> fzf" pick"fzf/fzf"
zi light junegunn/fzf-bin

zinit ice wait lucid from"gh-r" nocompile src'shell/key-bindings.zsh' sbin \
      dl'https://raw.githubusercontent.com/junegunn/fzf/master/shell/completion.zsh -> _fzf_completion;
         https://raw.githubusercontent.com/junegunn/fzf/master/shell/key-bindings.zsh -> key-bindings.zsh;
         https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf-tmux.1 -> $ZPFX/share/man/man1/fzf-tmux.1;
         https://raw.githubusercontent.com/junegunn/fzf/master/man/man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1'
zinit light junegunn/fzf

Is there any shorter way to do it?
I'd also like to skip using whole urls and simply using the content of junegunn/fzf plugin that I could install with zi light junegunn/fzf

Honestly, it felt like quite an achievement to get fzf working as I didn't find any documentation to do so (outside of just the binary itself)

[vladdoster]

I condensed the URLs using brace expansion (which can be optimized further).

zi for \
    as'command' \
    dl="$(print -c https://raw.githubusercontent.com/junegunn/fzf/master/{shell/{'key-bindings.zsh;','completion.zsh -> _fzf;'},man/{'man1/fzf.1 -> $ZPFX/share/man/man1/fzf.1;','man1/fzf-tmux.1 -> $ZPFX/share/man/man1/fzf-tmux.1;'}})" \
    from'gh-r' \
    null \
    pick'fzf' \
    src'key-bindings.zsh' \
  @junegunn/fzf

[ngocphamm]

Another behavior I'm confused about is that in those dl ice lines, I can use $ZPFX but not those $ZINIT[...] https://github.com/zdharma-continuum/zinit#customizing-paths

I tried to point the man file to $ZINIT[MAN_DIR], or the completion file to $ZINIT[COMPLETIONS_DIR] but a folder named $ZINIT[COMPLETIONS_DIR] is created, with the _fzf_completion file in it, instead.

atclone'echo $ZPFXl; echo $ZINIT[COMPLETIONS_DIR];' still can print the directories correctly though 🤔

Downloading junegunn/fzf...
(Requesting `fzf-0.35.1-darwin_amd64.zip'...)
####################################################################################################################################################################################################################################### 100.0%
[ziextract] Unpacking the files from: `fzf-0.35.1-darwin_amd64.zip'...
Archive:  fzf-0.35.1-darwin_amd64.zip
  inflating: fzf
[ziextract] Successfully extracted and assigned +x chmod to the file: fzf.
[patch-dl annex]: File fzf-tmux downloaded correctly
[patch-dl annex]: File _fzf_completion downloaded correctly
[patch-dl annex]: File key-bindings.zsh downloaded correctly
[patch-dl annex]: File fzf-tmux.1 downloaded correctly
[patch-dl annex]: File fzf.1 downloaded correctly
/Users/ngoc/.local/share/zinit/polaris
/Users/ngoc/.local/share/zinit/completions
bin-gem-node annex: Created the fzf shim and set +x on the fzf binary
bin-gem-node annex: Created the fzf-tmux shim and set +x on the fzf-tmux binary

[jankatins]

With latest HEAD, you should be able to use the "completion" ice to overwrite the behavior of as"null".

[ngocphamm]

Thank you! @jankatins So I've been looking at a new feature added just days ago, without having latest version. I thought I did zi update though.

Now _fzf_completion is being symlinked properly to $ZINIT[COMPLETIONS_DIR].

However, I think there's still something special with this. Normally, FZF would want to source the completion like this, and after that the function fzf-completion would be available.

[[ $- == *i* ]] && source "/usr/local/opt/fzf/shell/completion.zsh" 2> /dev/null

With zinit, even though zi clist | grep fzf shows that the plugin's completion has been loaded, type fzf-completion returns not found. 🤔

[jankatins]

I can reproduce, but have no idea why this is so... @vladdoster Maybe your debugging skills get this further...

(also found out that zinit completions for ... will print the completions, but zinit lbin"!" completions for ... will do the right thing. Not sure if thats a bug or a side effect...

[vladdoster]

@jankatins yeah I noticed the behavior of zinit completions for ... which makes sense since completions is a valid sub command.

[fky2015]

This plugin also does a wonderful job: https://github.com/joshskidmore/zsh-fzf-history-search