Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for newer versions of mb-wrapper and stream-decorators #234

Open
phpfui opened this issue Mar 27, 2024 · 6 comments
Open

Support for newer versions of mb-wrapper and stream-decorators #234

phpfui opened this issue Mar 27, 2024 · 6 comments

Comments

@phpfui
Copy link
Contributor

phpfui commented Mar 27, 2024

I noticed you now have newer version of stream-decorators and mb-wrapper that only support PHP 8.0 and higher! Big YES here!

But mail-mime-parser is still requiring the older versions. Are the new versions compatible with the 2.4 version? If so, do you want a PR to update the composer.json?

I was just doing a composer outdated and noticed this.

@zbateson
Copy link
Owner

Hi @phpfui

I'm working on a v3 release that'll be updated soon to include them. There's a small change I mostly finished working on to support them because they now throw an exception for unsupported charsets. It's been a very busy period so progress has been slow, sorry to you and anyone waiting! It's super close now :)

Because they throw exceptions and require php8, I will not be including them in 2.4.

Thanks again :)

@phpfui
Copy link
Contributor Author

phpfui commented Mar 27, 2024

Awesome! Let me know if you need any help or testing.

@zbateson
Copy link
Owner

Oh wow, yes, testing would be amazing. I'll do a beta release in a bit if you feel like playing around :)

@phpfui
Copy link
Contributor Author

phpfui commented Mar 28, 2024

Yes, let me know.

@zbateson
Copy link
Owner

zbateson commented Apr 15, 2024

Well that was a bit longer than expected, sorry!

Finally got a beta out there. I put some basic notes in 3.0.0-beta but honestly I don't know how helpful they are.

I still need to:

  • write some more tests for HeaderParts
  • add tests for some missing new HeaderPart classes and consumer classes
  • write the upgrade documentation page

I'll add more to that list if something else comes up.

@phpfui
Copy link
Contributor Author

phpfui commented Apr 15, 2024

I'll try this on a branch and see if I can set up a live server to test against. Will let you know of any issues, but might not be till next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants