Merge pull request #6926 from thc202/automation/set-output-state-always

automation: set default std output always

Author: psiinon

addOns/automation/CHANGELOG.md

@@ -7,6 +7,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### Changed
 - Make the "pass" output of Monitor Tests consistent with the "fail" output.
 
+### Fixed
+- Restore default standard output on absent `env` `parameters`.
+
 ## [0.56.0] - 2025-11-07
 ### Added
 - Command line -autocheck option which checks if the specified yaml plan has the right format.

addOns/automation/src/main/java/org/zaproxy/addon/automation/AutomationEnvironment.java

@@ -104,8 +104,6 @@ void readData(Map<?, ?> envData) {
                             Constant.messages.getString("automation.env.name"),
                             null,
                             progress);
-                    this.progress.setOutputToStdout(
-                            this.getData().getParameters().getProgressToStdout());
                     break;
                 case "proxy":
                     LinkedHashMap<?, ?> proxy = (LinkedHashMap<?, ?>) entry.getValue();
@@ -163,6 +161,9 @@ void readData(Map<?, ?> envData) {
                                     "automation.error.env.unknown", entry.getKey()));
             }
         }
+
+        progress.setOutputToStdout(getData().getParameters().getProgressToStdout());
+
         if (this.contexts.isEmpty()) {
             progress.error(Constant.messages.getString("automation.error.env.nocontexts", envData));
         }

addOns/automation/src/test/java/org/zaproxy/addon/automation/AutomationEnvironmentUnitTest.java

@@ -578,6 +578,35 @@ void shouldSetResolvedExcludeRegexes() {
                 .addExcludeFromContextRegex("https://www.prefix.envVarValue.example.com.*");
     }
 
+    @Test
+    void shouldHaveDefaultParams() {
+        // Given
+        String contextStr =
+                """
+                env:
+                 contexts:
+                   - name: context 1
+                     urls:
+                     - https://www.example.com
+                """;
+        Yaml yaml = new Yaml();
+        LinkedHashMap<?, ?> data =
+                yaml.load(new ByteArrayInputStream(contextStr.getBytes(StandardCharsets.UTF_8)));
+        LinkedHashMap<?, ?> contextData = (LinkedHashMap<?, ?>) data.get("env");
+        AutomationProgress progress = new AutomationProgress();
+
+        // When
+        AutomationEnvironment ae = new AutomationEnvironment(contextData, progress);
+
+        // Then
+        assertThat(progress.hasErrors(), is(equalTo(false)));
+        assertThat(progress.hasWarnings(), is(equalTo(false)));
+        assertThat(progress.isOutputToStdout(), is(equalTo(true)));
+        assertThat(ae.isFailOnError(), is(equalTo(true)));
+        assertThat(ae.isFailOnWarning(), is(equalTo(false)));
+        assertThat(ae.isContinueOnFailure(), is(equalTo(false)));
+    }
+
     @Test
     void shouldSetValidParams() {
         // Given
@@ -590,7 +619,8 @@ void shouldSetValidParams() {
                         + "  parameters:\n"
                         + "    failOnError: false\n"
                         + "    failOnWarning: true\n"
-                        + "    progressToStdout: true\n";
+                        + "    progressToStdout: false\n"
+                        + "    continueOnFailure: true";
         Yaml yaml = new Yaml();
         LinkedHashMap<?, ?> data =
                 yaml.load(new ByteArrayInputStream(contextStr.getBytes(StandardCharsets.UTF_8)));
@@ -605,8 +635,10 @@ void shouldSetValidParams() {
         assertThat(progress.getErrors().size(), is(equalTo(0)));
         assertThat(progress.hasWarnings(), is(equalTo(false)));
         assertThat(progress.getWarnings().size(), is(equalTo(0)));
+        assertThat(progress.isOutputToStdout(), is(equalTo(false)));
         assertThat(ae.isFailOnError(), is(equalTo(false)));
         assertThat(ae.isFailOnWarning(), is(equalTo(true)));
+        assertThat(ae.isContinueOnFailure(), is(equalTo(true)));
         assertThat(ae.isTimeToQuit(), is(equalTo(false)));
     }