Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate manifest to v3 #35

Closed
psiinon opened this issue Feb 24, 2023 · 10 comments · Fixed by #36
Closed

Migrate manifest to v3 #35

psiinon opened this issue Feb 24, 2023 · 10 comments · Fixed by #36
Labels
enhancement New feature or request

Comments

@psiinon
Copy link
Member

psiinon commented Feb 24, 2023

It looks like Firefox does now support manifest v3.
I tried just changing the version and it still loaded but it gave some warnings.
I've not has time to work out fixes for them yet, but the messagesd and docs on https://extensionworkshop.com/documentation/develop/manifest-v3-migration-guide/ look pretty good.

@psiinon psiinon added the enhancement New feature or request label Feb 24, 2023
@aryangupta701
Copy link
Contributor

Only for firefox? Why not for chrome also?

@psiinon psiinon changed the title Migrate Firefox manifest to v3 Migrate manifest to v3 Feb 26, 2023
@psiinon
Copy link
Member Author

psiinon commented Feb 26, 2023

Because I was looking at my local branch where I'd been playing around and had already migrated Chrome to v3 😁
I've changed the title...

@aryangupta701
Copy link
Contributor

I have successfully migrated it to v3 for firefox, but it breaks for chrome showing the error : Service worker registration failed. Status code: 15. I followed every step mentioned in the chrome migration from v2 to v3. https://developer.chrome.com/docs/extensions/mv3/mv3-migration/

@psiinon
Copy link
Member Author

psiinon commented Feb 26, 2023

Chrome tends to have better diagnostics that Firefox for problems like this, so have a dig around.
If you cant find anything then submit a PR anyway and I'll see if I can reproduce it 😁

@aryangupta701
Copy link
Contributor

okay.

@aryangupta701
Copy link
Contributor

I think the problem is with the webpack-extension-reloader we are using as explained in the issue below. I will look for some other alternative.
rubenspgcavalcante/webpack-extension-reloader#125 (comment)

@aryangupta701
Copy link
Contributor

aryangupta701 commented Feb 26, 2023

We can use this. What do you think about this?
https://github.com/SimplifyJobs/webpack-ext-reloader

@psiinon
Copy link
Member Author

psiinon commented Feb 27, 2023

Does the Chrome extension work if you reload it manually?
If so you can PR it like that and then submit another PR to fix any reloading issues.
The one you've linked to look=s like a good option 😁

@aryangupta701
Copy link
Contributor

no it does not work even if I load it manually. It gives the same error of service worker not being registered.

@psiinon
Copy link
Member Author

psiinon commented Feb 27, 2023

/in that case something else is up - if you cant work it out then submit a PR anyway and I'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants