Skip to content

Conversation

@eudelins-zama
Copy link
Contributor

@eudelins-zama eudelins-zama commented Nov 26, 2025

Closes https://github.com/zama-ai/fhevm-internal/issues/684

Forked from #1076.

I tried another approach, using workflow_call instead of workflow_dispatch for docker build workflows.
It felt more "natural", and avoid the need to poll for dispatched workflows using github-script.
But it required some boilerplate in these workflows.

I tested the test-suite-orchestrate-e2e-test.yml by commenting some if conditions to trigger/disable the workflows I wanted.
But now the final test would be to add this PR to the merge queue. So I guess we first need to review it, otherwise it could be merged

@cla-bot cla-bot bot added the cla-signed label Nov 26, 2025
@eudelins-zama eudelins-zama changed the title Eudelins/feat/mq/orchestrate e2e ci(common): mergify e2e tests workflow Nov 26, 2025
@eudelins-zama eudelins-zama force-pushed the eudelins/feat/mq/orchestrate-e2e branch 17 times, most recently from 10f72a1 to 282273f Compare November 27, 2025 08:40
@eudelins-zama eudelins-zama force-pushed the eudelins/feat/mq/orchestrate-e2e branch 4 times, most recently from 72d2654 to a5538d0 Compare November 27, 2025 09:26
@eudelins-zama eudelins-zama force-pushed the eudelins/feat/mq/orchestrate-e2e branch 10 times, most recently from c5949fd to 8cfc189 Compare November 27, 2025 12:23
@eudelins-zama eudelins-zama force-pushed the eudelins/feat/mq/orchestrate-e2e branch from 8cfc189 to 22be23a Compare November 27, 2025 12:51
Copilot finished reviewing on behalf of eudelins-zama November 27, 2025 12:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new CI workflow orchestration system for running E2E tests in Mergify merge queue environments. The changes enable Docker builds and tests to be triggered via workflow_call, allowing the new orchestrator workflow to coordinate builds across multiple components and then run E2E tests with the built images.

Key changes:

  • New orchestrator workflow that builds all components and runs E2E tests for merge queue PRs
  • Refactored existing Docker build workflows to support both direct triggers and workflow_call
  • New dedicated E2E test workflow for merge queue with custom component version handling
  • Updated actionlint configuration to suppress specific warnings
  • Package-lock.json peer dependency updates

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/test-suite-orchestrate-e2e-tests.yml New orchestrator workflow that coordinates docker builds and E2E tests for mergify merge queue
.github/workflows/test-suite-e2e-tests-mq.yml New workflow for running E2E tests with custom component versions via workflow_call
.github/workflows/*-docker-build.yml (13 files) Added workflow_call support with secrets, inputs, outputs, and conditional execution
.github/workflows/test-suite-e2e-tests.yml Removed merge queue trigger condition to avoid conflicts with orchestrator
.github/workflows/test-suite-e2e-tests-with-build.yml Removed commented-out pull_request trigger
.github/workflows/kms-connector-tests.yml Fixed path filter to be more specific
.github/workflows/common-pull-request-lint.yml Updated zizmor version and removed flags parameter
.github/actionlint.yaml Added path-specific ignore patterns for workflow validation
package-lock.json Added peer: true flags to numerous dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eudelins-zama eudelins-zama self-assigned this Nov 27, 2025
@eudelins-zama eudelins-zama marked this pull request as ready for review November 27, 2025 13:29
@eudelins-zama eudelins-zama requested a review from a team as a code owner November 27, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants