-
Notifications
You must be signed in to change notification settings - Fork 2.6k
ci(common): mergify e2e tests workflow #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
10f72a1 to
282273f
Compare
72d2654 to
a5538d0
Compare
c5949fd to
8cfc189
Compare
8cfc189 to
22be23a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a new CI workflow orchestration system for running E2E tests in Mergify merge queue environments. The changes enable Docker builds and tests to be triggered via workflow_call, allowing the new orchestrator workflow to coordinate builds across multiple components and then run E2E tests with the built images.
Key changes:
- New orchestrator workflow that builds all components and runs E2E tests for merge queue PRs
- Refactored existing Docker build workflows to support both direct triggers and workflow_call
- New dedicated E2E test workflow for merge queue with custom component version handling
- Updated actionlint configuration to suppress specific warnings
- Package-lock.json peer dependency updates
Reviewed changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/test-suite-orchestrate-e2e-tests.yml |
New orchestrator workflow that coordinates docker builds and E2E tests for mergify merge queue |
.github/workflows/test-suite-e2e-tests-mq.yml |
New workflow for running E2E tests with custom component versions via workflow_call |
.github/workflows/*-docker-build.yml (13 files) |
Added workflow_call support with secrets, inputs, outputs, and conditional execution |
.github/workflows/test-suite-e2e-tests.yml |
Removed merge queue trigger condition to avoid conflicts with orchestrator |
.github/workflows/test-suite-e2e-tests-with-build.yml |
Removed commented-out pull_request trigger |
.github/workflows/kms-connector-tests.yml |
Fixed path filter to be more specific |
.github/workflows/common-pull-request-lint.yml |
Updated zizmor version and removed flags parameter |
.github/actionlint.yaml |
Added path-specific ignore patterns for workflow validation |
package-lock.json |
Added peer: true flags to numerous dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes https://github.com/zama-ai/fhevm-internal/issues/684
Forked from #1076.
I tried another approach, using
workflow_callinstead ofworkflow_dispatchfor docker build workflows.It felt more "natural", and avoid the need to poll for dispatched workflows using
github-script.But it required some boilerplate in these workflows.
I tested the
test-suite-orchestrate-e2e-test.ymlby commenting someifconditions to trigger/disable the workflows I wanted.But now the final test would be to add this PR to the merge queue. So I guess we first need to review it, otherwise it could be merged