fix(coprocessor): gw-listener, reject suspicious urls for keys #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudy-6-4
force-pushed
the
rudy/fix/gw-listener/check-urls
branch
from
382cede to
634e625
Compare
obatirou
reviewed
Nov 12, 2025
| Ok(domain_parts[0].to_owned()) | ||
| } | ||
|
|
||
| fn is_url_suspicious(parsed_url_and_bucket: &Url) -> bool { |
Collaborator
There was a problem hiding this comment.
no unit test?
Else lgtm
My understanding, url is suspicious if there are any of:
- query
- fragment
- username
- password
- not http or https
- no host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.