-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More documentation #249
Comments
#237 |
Great, thanks! I don't want to sound ungrateful, but is this documented somewhere? I had to look through the pull request comments in order to figure it out. I'm also getting a type error so maybe I'm still doing something wrong? (the inputs are hidden now though so that's great) I'm setting the config as follows:
the type error I get is
|
Hey @thijs-qv, Feel free to open a PR for additional documentation; contributions are always welcomed! |
Thank you! I’ll see if I can add some documentation when I’m a bit more familiar with the project and the codebase. |
When I use this config I see message: TS2322: Type '{ hideSubject: true; hideSubTitle: true; }' is not assignable to type 'IntrinsicAttributes'. Property 'hideSubject' does not exist on type 'IntrinsicAttributes'. |
Hi, I managed to fix the issue by setting the returned type of const MyDefaultPageConfigPanel: typeof DefaultPageConfigPanel =
BlockAttributeConfigurationManager.get(BasicType.PAGE);
BlockAttributeConfigurationManager.add({
[BasicType.PAGE]: () => <DefaultPageConfigPanel hideSubject hideSubTitle />,
}); Hope this helps |
Can there please be more documentation added to the project? There are all sorts of cool options and things available but it's difficult to find information on them.
e.g.
I'd like to hide the "subject" and "subtitle" input boxes in the AttributesPanel. I can see that the Page block of the AttributesPanel has the following props}
How would I pass these options via the EmailEditor / EmailEditorProvider props?
The text was updated successfully, but these errors were encountered: