Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing export types Roi.ts #146

Closed
tpoisseau opened this issue Apr 25, 2024 · 5 comments
Closed

Missing export types Roi.ts #146

tpoisseau opened this issue Apr 25, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@tpoisseau
Copy link

src/types/Roi.ts

Members of this file should be exported from src/index.ts
@tpoisseau tpoisseau added the good first issue Good for newcomers label Apr 25, 2024
@stropitek
Copy link
Contributor

Most of what is in Roi.ts should not be exported by the library.

Is there a specific type that you needed in there?

@tpoisseau
Copy link
Author

getScanRoiStyle method for document anonymization into our main internal project

@stropitek
Copy link
Contributor

getScanRoiStyle method for document anonymization into our main internal project

but this seems unrelated to the types src/types/Roi.ts exports

@tpoisseau
Copy link
Author

No, this method use this path import (import { Roi } from 'react-roi/src/types/Roi';)

@stropitek
Copy link
Contributor

Superseeded by #147

@stropitek stropitek closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stropitek @tpoisseau