Skip to content

Commit 7756b11

Browse files
committed
Refactors, slimmer code
1 parent 750e8fe commit 7756b11

File tree

6 files changed

+22
-39
lines changed

6 files changed

+22
-39
lines changed

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
},
3434
"autoload": {
3535
"psr-4": {
36-
"Zacksmash\\LaravelRouteActions\\": "src/"
36+
"Zacksmash\\SoftDeleteRoutes\\": "src/"
3737
}
3838
},
3939
"autoload-dev": {
@@ -55,7 +55,7 @@
5555
"extra": {
5656
"laravel": {
5757
"providers": [
58-
"Zacksmash\\LaravelRouteActions\\Providers\\RoutingServiceProvider"
58+
"Zacksmash\\SoftDeleteRoutes\\Providers\\RoutingServiceProvider"
5959
]
6060
}
6161
},

src/Providers/RoutingServiceProvider.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22

3-
namespace Zacksmash\LaravelRouteActions\Providers;
3+
namespace Zacksmash\SoftDeleteRoutes\Providers;
44

55
use Illuminate\Foundation\Application;
66
use Illuminate\Routing\Router;
@@ -14,7 +14,7 @@ class RoutingServiceProvider extends ServiceProvider
1414
public function register(): void
1515
{
1616
$this->app->extend(Router::class, function (Router $router, Application $app) {
17-
return new \Zacksmash\LaravelRouteActions\Routing\Router($router, $app);
17+
return new \Zacksmash\SoftDeleteRoutes\Routing\Router($router, $app);
1818
});
1919
}
2020

src/Routing/PendingResourceRegistration.php

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,19 @@
11
<?php
22

3-
namespace Zacksmash\LaravelRouteActions\Routing;
3+
namespace Zacksmash\SoftDeleteRoutes\Routing;
44

55
use Illuminate\Routing\PendingResourceRegistration as BasePendingResourceRegistration;
66

77
class PendingResourceRegistration extends BasePendingResourceRegistration
88
{
9-
/**
10-
* Create a new pending resource registration instance.
11-
*
12-
* @param \Illuminate\Routing\ResourceRegistrar $registrar
13-
* @param string $name
14-
* @param string $controller
15-
* @return void
16-
*/
17-
public function __construct($registrar, $name, $controller, array $options)
18-
{
19-
parent::__construct($registrar, $name, $controller, $options);
20-
}
21-
229
/**
2310
* Add a restore method to the resource.
2411
*/
2512
public function withRestore(): self
2613
{
27-
$this->registrar->setResourceDefault('restore');
14+
$this->registrar->verbs(['restore' => 'restore']);
15+
16+
$this->registrar->resourceDefaults('restore');
2817

2918
$this->options['trashed']['restore'] = true;
3019

@@ -36,7 +25,9 @@ public function withRestore(): self
3625
*/
3726
public function withErase(): self
3827
{
39-
$this->registrar->setResourceDefault('erase');
28+
$this->registrar->verbs(['erase' => 'erase']);
29+
30+
$this->registrar->resourceDefaults('erase');
4031

4132
$this->options['trashed']['erase'] = true;
4233

src/Routing/ResourceRegistrar.php

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,23 @@
11
<?php
22

3-
namespace Zacksmash\LaravelRouteActions\Routing;
3+
namespace Zacksmash\SoftDeleteRoutes\Routing;
44

55
use Illuminate\Routing\ResourceRegistrar as BaseRegistrar;
66

77
class ResourceRegistrar extends BaseRegistrar
88
{
99
/**
10-
* Create a new resource registrar instance.
10+
* Get or set the resource defaults used in resourcful controllers.
11+
*
12+
* @return array|void
1113
*/
12-
public function __construct(Router $router)
14+
public function resourceDefaults(?string $method = null)
1315
{
14-
parent::__construct($router);
16+
if (! $method) {
17+
return $this->resourceDefaults;
18+
}
1519

16-
self::$verbs = [
17-
'restore' => 'restore',
18-
'erase' => 'erase',
19-
...parent::$verbs,
20-
];
21-
}
22-
23-
/**
24-
* Add a resource method to the resource defaults.
25-
*/
26-
public function setResourceDefault(string $method): string
27-
{
28-
return $this->resourceDefaults[] = $method;
20+
$this->resourceDefaults[] = $method;
2921
}
3022

3123
/**

src/Routing/Router.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?php
22

3-
namespace Zacksmash\LaravelRouteActions\Routing;
3+
namespace Zacksmash\SoftDeleteRoutes\Routing;
44

55
use Illuminate\Routing\Router as BaseRouter;
66

tests/TestCase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace Tests;
44

55
use Orchestra\Testbench\TestCase as BaseTestCase;
6-
use Zacksmash\LaravelRouteActions\Providers\RoutingServiceProvider;
6+
use Zacksmash\SoftDeleteRoutes\Providers\RoutingServiceProvider;
77

88
class TestCase extends BaseTestCase
99
{

0 commit comments

Comments
 (0)