Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect implementation of custom errors for some common error types #110

Open
nikitawootten opened this issue Jun 6, 2022 · 0 comments
Open

Incorrect implementation of custom errors for some common error types #110

nikitawootten opened this issue Jun 6, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@nikitawootten
Copy link
Contributor

Bug Report:

Some errors in errors.go are just instances of errors, and not custom types that implement the error interface.

Tests for errors such as ErrNotFound can not directly be done without searching for error content.

Expected Behavior

errors.As() allows you to test if a GoGM error is a specific type, such as a ErrNotFound, ErrConnection, etc..

Current Behavior

Many errors do not implement the error

Possible Solution

Correctly implement custom errors
@nikitawootten nikitawootten added the bug Something isn't working label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikitawootten