Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material 3 colors issues #1376

Closed
4 tasks done
mostafaalagamy opened this issue Aug 14, 2024 · 15 comments
Closed
4 tasks done

Material 3 colors issues #1376

mostafaalagamy opened this issue Aug 14, 2024 · 15 comments
Labels
bug Something isn't working

Comments

@mostafaalagamy
Copy link

Checklist

  • I am able to reproduce the bug with the latest debug version.
  • I've checked that there is no open or closed issue about this bug.
  • This issue contains only one bug.
  • The title of this issue accurately describes the bug.

Steps to reproduce the bug

Is this normal? The color of the search bar and the navigation bar has become a different colors from the app's background, and this is strange.

New colors

Screenshot_2024-08-14-07-32-27-780_com zionhuang music-edit

It would be better if it was the same color like this.

Screenshot_2024-08-13-21-31-09-490_com dd3boh outertune

Expected behavior

__

Actual behavior

__

Screenshots/Screen recordings

No response

Logs

__

InnerTune version

debug version

Android version

13

Additional information

No response

@mostafaalagamy mostafaalagamy added the bug Something isn't working label Aug 14, 2024
@Richard38907
Copy link

Same here, this is weird

@z-huang
Copy link
Owner

z-huang commented Aug 14, 2024

It's correct according to material 3 guidelines, which has updated since Dec, 2023. It says search bar container color is md.sys.color.surface-container-high and navigation bar container color is md.sys.color.surface-container.

@Richard38907
Copy link

We think the old one was better. These "light grey" UI elements look bad.
Same report for Malopieds version here:
Malopieds#311

@mostafaalagamy
Copy link
Author

It's correct according to material 3 guidelines, which has updated since Dec, 2023. It says search bar container color is md.sys.color.surface-container-high and navigation bar container color is md.sys.color.surface-container.

If all the colors in the app need to be changed to match each other, what should be done?

@ae5960e8-a6fc-491f-b252-898ecf59af95

In my opinion, the ideal color is the one we had before the change. The whole app looks wrong to me now.

It's correct according to material 3 guidelines, which has updated since Dec, 2023. It says search bar container color is md.sys.color.surface-container-high and navigation bar container color is md.sys.color.surface-container.

Following Google's rules so far has been great, but this change lowers the UI's cohesiveness, so I think you should consider making your own decision here as arguably your design looks more like Material 3 than Google's.

@mostafaalagamy
Copy link
Author

In my opinion, the ideal color is the one we had before the change. The whole app looks wrong to me now.

It's correct according to material 3 guidelines, which has updated since Dec, 2023. It says search bar container color is md.sys.color.surface-container-high and navigation bar container color is md.sys.color.surface-container.

Following Google's rules so far has been great, but this change lowers the UI's cohesiveness, so I think you should consider making your own decision here as arguably your design looks more like Material 3 than Google's.

It's normal to follow the rules, but in the case of innertune, some colors were changed while others were not. If we follow Google's rules for the navigation bar and search bar, we should also follow them for the background and other colors to ensure everything is seamless and not weird.

For example, to clarify!

Screenshot_2024-08-19-09-10-22-295_com.android.chrome-edit.jpg

Screenshot_2024-08-19-09-01-03-357_com.android.chrome-edit.jpg

@z-huang
Copy link
Owner

z-huang commented Aug 19, 2024

Good point! Added.

@mostafaalagamy
Copy link
Author

Good point! Added.

The colors are still different, something is missing.

Screenshot_2024-08-19-16-41-48-514_com.zionhuang.music.debug.jpg

@z-huang
Copy link
Owner

z-huang commented Aug 19, 2024

Where do you mean? I have changed background color to Surface.

@mostafaalagamy
Copy link
Author

Where do you mean? I have changed background color to Surface.

I know it has been changed, but the colors are still not harmonious and haven't changed properly. Look at Google Play or Google Phone, you'll see that the background color matches the navigation bar and the search bar but in different shades. However, in our case, you'll find that they are completely different from the background color even after the change. That's why I'm telling you that something is missing and hasn't been adjusted.

Screenshot_2024-08-19-20-11-45-630_com.android.vending.jpg

Screenshot_2024-08-19-20-13-50-674_com.zionhuang.music.debug-edit.jpg

color differences :

1- search bar
2- background
3- circle box
4- Buttons
5- navigation bar

@z-huang
Copy link
Owner

z-huang commented Aug 20, 2024

@mostafaalagamy check out this one: 57428ce

@mostafaalagamy
Copy link
Author

@mostafaalagamy check out this one: 57428ce

I think it's better now than it was before. thanks!

@ae5960e8-a6fc-491f-b252-898ecf59af95

I think my concern is exclusive to "Pure black" mode. Could you check that? In that mode the theme it looks wrong to me.

@z-huang
Copy link
Owner

z-huang commented Aug 21, 2024

Can you provide screenshots?

@ae5960e8-a6fc-491f-b252-898ecf59af95

In the current version it looks like this:
nmbhxahmxa5whijo

In the previous version, the "Pure black" theme appeared as true black, which is consistent with the behavior of other Material 3 apps I use. Therefore, I suspect there may be an issue with the implementation of the "Pure black" theme in this version.

Additionally, it might be beneficial to consider utilizing the "Pure black" system theme to automatically adjust the theme based on the user's system settings. However, this is not the primary concern at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants