-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bind log functions to sanitized context #27 #29
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 67 67
Branches 18 18
=====================================
Hits 67 67
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change the space formatting everywhere..
This also makes the PR very hard to review
Only make changes on what's needed
|
So basically the Is this compatible will all Azure Function runtimes? What Azure Function version are you using? I'm also thinking.. in a further commit, to pass |
I think, Yes, you do not have to bind the log function. |
Tested on V2. It is also working as expected. Seems, nothing is broken with the fix |
Dear Yvele, We are using this library in production, and we are blocked because of this issue(without context.log.error support we can not monitor azure function for any errors or downtime as in appinsight we look for errors). Highly appreciate if you can release a minor version asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorporated formatting changes
So what is the status here? |
Closes #27
Fix for issue 27 support for log, info,error, warn and verbose methods of context objects
Following are the screenshot :