Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations are attached to the latest commit on a pull request #4

Open
ggrossetie opened this issue Dec 17, 2020 · 0 comments
Open

Comments

@ggrossetie
Copy link
Member

Currently, running this action on a pull request can create some confusing scenarios where you navigate from an annotation to a commit that didn't alter the file. I guess the "correct" behaviour would be to scan through all the commits in the pull request and create check runs for each commit with the issues for each affected file, which would be a lot of work if it is even possible.

I'm left wondering whether it's just a bad idea to create annotations on pull requests?

Originally posted by @hcoles in #3 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant