Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curious Actor Optimizer using Actor model parameters #4

Open
someone-ml opened this issue Apr 6, 2022 · 1 comment
Open

Curious Actor Optimizer using Actor model parameters #4

someone-ml opened this issue Apr 6, 2022 · 1 comment

Comments

@someone-ml
Copy link

if args.algo=="p2e":

Hello, I was wondering, when using p2e algorithm, why do we pass actor_model parameters into curious_actor_optimizer? Same happens with value_model_optimizer and value_model.

In the way I see it, this is bug because curious_actor_model doesn't learn anything while exploring environment with p2e and the way to fix it is to pass curious_actor_model parameters and curious_value_model parameters into curious_actor_optimizer and value_model_optimizer respectively.

@seolhokim
Copy link

you're right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants