-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DocDB] Remove unused headers in catalog_manager.h and client.h #26589
Labels
area/docdb
YugabyteDB core features
kind/enhancement
This is an enhancement of an existing feature
priority/low
Low priority
Comments
SrivastavaAnubhav
added a commit
that referenced
this issue
Mar 30, 2025
…ent.h Summary: These are some of the most heavily included files and each header within them that they also include must be parsed in every downstream use, which greatly increases build time. This diff removes some unused headers. The majority of the savings comes from cleaning up dockv_fwd.h to not include dockv/value_type.h, and keeping metrics.h from being included in so many files. This speeds up the build by 178 CPU seconds, or 17.8s on my M1 mac. Jira: DB-15960 Test Plan: ``` ./yb_build.sh daemons --no-ccache --skip-tests --clean ClangBuildAnalyzer --all build/latest capture.out ClangBuildAnalyzer --analyze capture.out > results.out ``` Results before: {F344021} Results after: {F344022} Reviewers: hsunder Reviewed By: hsunder Subscribers: yql, ybase Differential Revision: https://phorge.dev.yugabyte.com/D42837
Build fails on Ubuntu 24.04 with GCC13 after 83dc8ed
Builds OK after |
SrivastavaAnubhav
added a commit
that referenced
this issue
Apr 1, 2025
Summary: Commit 83dc8ed removes some unused headers. `tserver_xcluster_context_mock.h` actually used one of these headers on gcc13 (even though it probably shouldn't and a forward declaration should be enough, but we're using an extremely old gmock framework). This diff adds the header to that file to fix the build. Jira: DB-15960 Test Plan: ./yb_build.sh --gcc13 Jenkins: compile only Reviewers: amartsinchyk Reviewed By: amartsinchyk Subscribers: ybase Differential Revision: https://phorge.dev.yugabyte.com/D42894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/docdb
YugabyteDB core features
kind/enhancement
This is an enhancement of an existing feature
priority/low
Low priority
Jira Link: DB-15960
Description
These are some of the most heavily included files and each header within them that must be parsed greatly increases build time.
Issue Type
kind/enhancement
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: