Skip to content

Commit

Permalink
[CLOUDGA-24871] Remove feature flag from DB Query Logging (#279)
Browse files Browse the repository at this point in the history
* [CLOUDGA-24871] Remove feature flag from DB Query Logging
  • Loading branch information
bhupendray-yb authored Dec 5, 2024
1 parent d4ebaa6 commit 751c5a9
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion cmd/cluster/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ var ClusterCmd = &cobra.Command{
func init() {
ClusterCmd.AddCommand(cert.CertCmd)

util.AddCommandIfFeatureFlag(ClusterCmd, log_exporter.DbQueryLoggingCmd, util.DB_QUERY_LOGS)
ClusterCmd.AddCommand(log_exporter.DbQueryLoggingCmd)
log_exporter.DbQueryLoggingCmd.PersistentFlags().StringVarP(&log_exporter.ClusterName, "cluster-name", "c", "", "[REQUIRED] The name of the cluster.")
log_exporter.DbQueryLoggingCmd.MarkPersistentFlagRequired("cluster-name")

Expand Down
1 change: 0 additions & 1 deletion cmd/db_query_logs_exporter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ var _ = Describe("DB Query Logging", func() {
Expect(err).ToNot(HaveOccurred())
os.Setenv("YBM_HOST", fmt.Sprintf("http://%s", server.Addr()))
os.Setenv("YBM_APIKEY", "test-token")
os.Setenv("YBM_FF_DB_QUERY_LOGGING", "true")
statusCode = 200
err = loadJson("./test/fixtures/list-clusters.json", &responseListClusters)
Expect(err).ToNot(HaveOccurred())
Expand Down
1 change: 0 additions & 1 deletion cmd/util/feature_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ const (
CONNECTION_POOLING FeatureFlag = "CONNECTION_POOLING"
GOOGLECLOUD_INTEGRATION FeatureFlag = "GOOGLECLOUD_INTEGRATION"
DR FeatureFlag = "DR"
DB_QUERY_LOGS FeatureFlag = "DB_QUERY_LOGGING"
)

func (f FeatureFlag) String() string {
Expand Down

0 comments on commit 751c5a9

Please sign in to comment.