Merge pull request #284 from ReyisaRuby/txndb_add

ReyisaRuby · web-flow · commit 522df2198b24 · 2025-02-18T11:30:46.000+08:00
fix ordered txn GetAll
diff --git a/core/txpool/ordered.go b/core/txpool/ordered.go
@@ -139,9 +139,9 @@ func (ot *orderedTxns) SortTxns(fn func(txns []*SignedTxn) []*SignedTxn) {
 }
 
 func (ot *orderedTxns) GetAll() []*SignedTxn {
-	txns := make([]*SignedTxn, 0)
 	ot.RLock()
 	defer ot.RUnlock()
+	txns := make([]*SignedTxn, 0, len(ot.txns))
 	for _, txn := range ot.txns {
 		txns = append(txns, txn)
 	}

Original file line number	Diff line number	Diff line change
`@@ -139,9 +139,9 @@ func (ot orderedTxns) SortTxns(fn func(txns []SignedTxn) []*SignedTxn) {`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`func (ot orderedTxns) GetAll() []SignedTxn {`
`142`		`- txns := make([]*SignedTxn, 0)`
`143`	`142`	`ot.RLock()`
`144`	`143`	`defer ot.RUnlock()`
	`144`	`+ txns := make([]*SignedTxn, 0, len(ot.txns))`
`145`	`145`	`for _, txn := range ot.txns {`
`146`	`146`	`txns = append(txns, txn)`
`147`	`147`	`}`