-
-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
animations #1121
Comments
Forks that implements animation: |
... and mine, https://github.com/dccsillag/picom, which is what pijulius, FT-Labs and fdev31 forked from (and what the long-standing PR #772 was from). |
Oh yeah i kinda forgot about yours.... Thanks for reminding me though :D |
i can't check out the discord thread, looks like the invitation link has expired! i would be happy to hear an update about picom animations 🫠 |
thanks for pointing out. i copied it from the discord badge in the readme but it turned out that it wasn't updated when it was changed so i updated it both in the readme and here.
unfortunately, there are no updates. |
Still want animation support. Done. Here is my public, actively maintained, on the AUR fork of pijulius picom. Now on NixOS and Nixpkgs and I am always looking to add new features. Links: https://github.com/allusive-dev/picom-allusive |
Hi, I want to quickly ( 🤞 ) merge animation support after v11 release (which should be in the next few weeks, again 🤞 ). looks like @FT-Labs' fork is the most comprehensive one? so maybe i will consolidate all the PR's around that. now, I realized I never asked if @FT-Labs wants to merge their branch into this repo, i just assumed they do 😅 I will still do this either way (these are all open source after all), but if @FT-Labs wants to, we can work together and sort this all out faster than I can with only current picom developers. |
And if @FT-Labs's fork has missing features, or there is another fork I need to look at, or something, please leave a comment. |
And I would definitely appreciate @dccsillag's help as well if he has more time and is able to. |
Hello @yshui, Yes, I'm totally up for it. That would be great, because this is a work that needs more than 1 person. Any help would be appreciated, I would be glad to explain what I have done until now and explain all of the steps. |
@yshui |
I'd be happy to help. (Still a bit strained for time, though!) |
I tried out @jasper-at-windswept's fork because I was curious, and the animations are cool, but the following would need some work, imo:
It would also be great to be able to set all animation settings using rules, rather than only being able to exclude windows from opening and unmapping animations. This would allow one tweak animations in a very fine-grained way, it'd be great for e.g. menus, docks, launchers, notifications, etc. Here is a recording (i3wm): picom-animations.mp4For reference, my config is here: https://github.com/zeorin/dotfiles/blob/07f0c9bf789f8baebc40afd3b06c5586b7a0caf8/home-manager/home.nix#L2618-L2803 |
@jasper-at-windswept I intend to take from @FT-Labs 's fork, as IIUC it is the most up-to-date version. |
Hi, can you open a PR from your branch? |
No problem. Looking forward to animations in v11! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Also feel free to try out my fork, it is based on FT-Labs and has animation customization throughout: rules, xprop, wintypes. May be helpful to take particular parts from it (https://github.com/XoDefender/picom) |
@0neGal i am looking into the unredir issue. but it looks like when the screen is unredirected, animation already doesn't start. do you have steps for how to reproduce this issue? |
Hmm, didn't test this originally, so thought it was a general unredir and animation issue, but I can't actually reproduce it very well with certain configs, here however is one that does reproduce it: Barebones configbackend = "glx";
unredir-if-possible = true;
rules = (
# this just makes it easier to notice the unredir
{ opacity = 0.9; match = "class_g %= '*'"; },
{ opacity = 1.0; match = "fullscreen"; },
{ unredir = true; match = "_NET_WM_BYPASS_COMPOSITOR = 1"; }
)
animations = (
{
duration = 0.2;
triggers = ["open", "show"];
opacity = {
start = 0; end = "window-raw-opacity";
duration = "duration"; curve = "linear";
}
},
{
duration = 0.2;
triggers = ["close", "hide"];
opacity = {
start = 0.8; end = 0;
duration = "duration"; curve = "linear";
}
}
) Note that removing the opacity reset Also just discovered now, that this only happens when something like Dunst or Rofi is currently on screen, but |
what do i need to do to trigger unredir with this config? |
Open a window that has override redirect, i.e Rofi without |
Do i have to have no other windows open? running rofi doesn't unredirect. |
Oh my bad, read it incorrectly, to unredir you just need a window with The Rofi part is what causes the unredir to momentarily disable itself... |
what i am seeing is that as long as rofi is open, unredir is disabled, which is expected. i don't see the momentary disablement. could be WM related? |
I think the momentary part might just be my setup where an unredir app launches very momentarily, I do feel like I recall it happening on regular windows, but I can't personally reproduce that right now. I'll report back if I find a reproducible situation where that happens again... Is there a way to prevent override redirects from disabling unredir however? That's really my issue, currently whenever I get a notification unredir disables, which can cause some stuttering when enabling and disabling, especially under a load. |
@0neGal try |
Doesn't seem to have any effect, and the rule does match and apply when checking with |
@0neGal where did you put it in your config file? |
As the last rule at first, but I also tried a before the |
looks like there is a bug with setting the |
missed a Line 542 in d785401
|
fixed in |
Just compiled a patched build myself before this, and can confirm, works as intended now! |
@kingdomkind I applied your suggested settings in Picom. The MANUAL has been configured correctly in Awesome, but all client windows appear fully black and are not being rendered by Picom. This seems to be causing significant rendering issues. |
@raven2cz the rule you added shouldn't change rendering when the animation is not triggered though. |
This worked fine for me, using my own window manager (assuming the syntax is fine) |
@kingdomkind Thanks for the info, could you share a link or file with your configuration? I'll try your setup or compare the changes. After all, my |
https://github.com/kingdomkind/pika-archconfig/blob/5414fc26590bad61d3f7f5b437e1a91d0b50c6fb/picom.conf |
@kingdomkind Interesting your configuration works! I'll try to set it all up with it. Thank you very much. This original configuration of mine causes the windows inside not to render at all if I uncomment the animations and rules at the bottom: But that's just for your information. I'll then try to make some compromise between the settings. Thanks! |
@raven2cz i figured out what's wrong, should be fixed now. |
Not sure if it is intended, but I find the following effect a little jarring: During the picom-anim.mp4Is it meant to look this way ? Or am I missing a parameter to have the corners always be rounded ? |
@g-wizzy but the rounded corner is still there? or do you mean the corners at the top? corners are still rounded, but the top half of the window is cropped out so you don't see the top corners. |
@yshui The fact that the corners are cropped during the animation is what I am talking about yes. During the slide-in, the corners at the top are squared, and I was asking if this was intentional. |
yeah, slide-in crops the window. |
is there currently a way to disable animations for a window rule? |
@PassiveLemon, yes, using the |
All I see is how to define animations for specific window types, there's no obvious way to disable them. Well I effectively disabled them by setting these for the match.
Definitely not a solution I like though. Maybe just a simple animations = false? |
since there are multiple open issues requesting animations i decided to group them into a single issue to have a more or less centralized discussion, ease the progress tracking and reduce the amount of open issues.
there is also a thread in the #development channel on the discord server to ease the communication between developers interested in implementing animations.
feel free to reserve one of the first posts in this issue if you're interested in structuring it even more.
related issues:
related discussions:
related pull requests:
forks that implement animations:
feel free to post here or ping me on the discord server about additions to the lists above.
The text was updated successfully, but these errors were encountered: