Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass any other keys than arrows during volume adjustment #3

Open
ivnc opened this issue May 31, 2019 · 1 comment
Open

Don't pass any other keys than arrows during volume adjustment #3

ivnc opened this issue May 31, 2019 · 1 comment
Assignees

Comments

@ivnc
Copy link

ivnc commented May 31, 2019

A Spanish-speaking user has complained through Twitter about the fact that, if you press any other key than arrows during volume adjustment such as Enter, this is passed to NVDA anyway.

Steps to reproduce (case example)

This is the user's particular scenario, a completely valid example to demonstrate this.

  1. He focused the NVDA shortcut on Desktop.
  2. He started volume setting by activating the add-on command layer.
  3. Then he pressed Enter, by custom, to confirm the changes he had just made.
    I've tested this with this repository's webpage in Firefox and one-letter navigation commands are also passed to NVDA, what suggests a general behavior.

Current behavior

Key presses are passed to NVDA despite being on the add-on command layer.

Suggested behavior

Block all other keys different from arrows and the keystroke to disable the add-on layer. Either notify the user or automatically exit the layer if one of these is pressed.

@yplassiard yplassiard self-assigned this Jun 2, 2019
@yplassiard
Copy link
Owner

Accepted

This is indeed something which may be confusing at some point. I will figure out how I can either block key presses, or indicate that we exited the adjust volume layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants