Switch 컴포넌트 추가 #13
Open
Switch 컴포넌트 추가 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
reviewed
Sep 23, 2024
Comment on lines
128
to
130
| // Switch의 Track의 모서리를 둥글게 만들기 위한 상수입니다. | ||
| private const val SwitchTrackRoundedCorner = 999 | ||
|
|
There was a problem hiding this comment.
둥근 모서리를 999 주는 거랑 CircleShape로 그냥 둥글게 만드는 거와의 차이가 있을까요...?
There was a problem hiding this comment.
아이고 너무 늦게 봤네요.. figma에 나와있는 값을 그대로 사용했는데 CircleShape랑 어떻게 다른지 모르겠네요. 알아보겠습니다.
There was a problem hiding this comment.
조금 늦었지만 지금 다시 보니 figma에 해당 세팅이 더이상 없네요. 아무튼 모서리의 반경을 999처럼 큰 값을 하면 CircleShape와 차이가 없습니다
cometj03
reviewed
Oct 11, 2024
Comment on lines
26
to
39
| val switchStates = | ||
| listOf(SwitchState.Unselected, SwitchState.Selected, SwitchState.Disabled) | ||
| val switchSizes = listOf(SwitchSize.Large, SwitchSize.Medium, SwitchSize.Small) | ||
|
|
||
| switchStates.forEach { state -> | ||
| switchSizes.forEach { size -> | ||
| samples.add( | ||
| SwitchPreviewParameter( | ||
| switchState = state, | ||
| switchSize = size | ||
| ) | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| val switchStates = | |
| listOf(SwitchState.Unselected, SwitchState.Selected, SwitchState.Disabled) | |
| val switchSizes = listOf(SwitchSize.Large, SwitchSize.Medium, SwitchSize.Small) | |
| switchStates.forEach { state -> | |
| switchSizes.forEach { size -> | |
| samples.add( | |
| SwitchPreviewParameter( | |
| switchState = state, | |
| switchSize = size | |
| ) | |
| ) | |
| } | |
| } | |
| val switchStates = | |
| listOf(SwitchState.Unselected, SwitchState.Selected, SwitchState.Disabled) | |
| val switchSizes = listOf(SwitchSize.Large, SwitchSize.Medium, SwitchSize.Small) | |
| val samples = switchStates.flatMap { state -> | |
| switchSizes.map { size -> SwitchPreviewParameter(state, size) } | |
| } |
밖에 LaunchedEffect도 없어도 될 것 같네요
cometj03
reviewed
Oct 11, 2024
Comment on lines
59
to
64
| fun Switch( | ||
| switchState: SwitchState = SwitchState.Unselected, | ||
| onToggle: (SwitchState) -> Unit, | ||
| switchSize: SwitchSize = SwitchSize.Large, | ||
| modifier: Modifier = Modifier | ||
| ) { |
There was a problem hiding this comment.
Suggested change
| fun Switch( | |
| switchState: SwitchState = SwitchState.Unselected, | |
| onToggle: (SwitchState) -> Unit, | |
| switchSize: SwitchSize = SwitchSize.Large, | |
| modifier: Modifier = Modifier | |
| ) { | |
| fun Switch( | |
| onToggle: (SwitchState) -> Unit, | |
| modifier: Modifier = Modifier, | |
| switchState: SwitchState = SwitchState.Unselected, | |
| switchSize: SwitchSize = SwitchSize.Large, | |
| ) { |
순서 변경해주세요!
cometj03
reviewed
Oct 11, 2024
Comment on lines
140
to
145
| Surface( | ||
| modifier = modifier | ||
| .clip(CircleShape) | ||
| .size(switchThumbSize(switchSize)), | ||
| contentColor = HandyTheme.colors.switchThumb, | ||
| ) {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handy Component 중 Switch의 제작을 완료했습니다.
Describe your changes
To reviewers
4d198f5 : 시맨틱 색상 추가 커밋
0906624 : 스위치의 구현을 완료 커밋
f288d2f : 스위치에 ease 에니메이션 추가 커밋
@yourssu/android-maintainer