Minor issues in staging

[sarinasindurakar]

• Issue 1
  When user tries to publish the activity from the activity detail page, the core element is complete message is shown even when core element is not completed.
  

• Issue 2 (Salil)
  The download xls popup is shown only after refreshing the page.

• Issue 3
  When user edits the API token and verify the invalid token, the tag is shown correct.
  

• Issue 4
  IATI Validator message of sector and transaction is navigating the user to setting page.
  

• Issue 5
  When user downloads the csv file for activity, the date is being downloaded in the humanitarian vocabulary column.

• Issue 6
  When user imports the activity including the sector , recipient region and country in both transaction and activity level using the csv, xls and xml, both sector and recipient region and country in the activity and transaction level is disabled and data is shown in both the form.

• Issue 7
  Add validation in the result reference and indicator reference .If the reference vocabulary and code in added in the result level then it cannot be included in the indicator level and vice versa.

• Issue 8 (Salil)
  The support button is overlapping bulk publishing modal
  

• Issue 9
  When user adds the same language in the sector narrative no error message is shown.

• Issue 10
  When user edits and tries to update the organization identifier and humanitarian scope , error message is shown but data is updated.
• Issue 11 (Salil)
  When user cancels the import and again upload the file, the file upload popup is shown only after refreshing the page.

[sarinasindurakar]

• 12 Add question mark in the last line.

• 13 The organization registration agency value flickers in the organization identifier edit form.

IATI.Publisher.Dev.-.24.July.2023.mp4

[rajkarnikar11]

issue 2: Is not an issue.
issue 8 : Solved by moving the support button to the left when the bulk publish component is expanded
issue 11 :The state(in vuex) was not changed while canceling the import , fixed by updating state in vuex while the import model is cancled

[PG-Momik]

issue 1: Added explicit completeness check that was missing
issue 3: Changed logic to determine type of response from api when validating token
issue 7: Added validation rule to check if result reference OR indicator reference exists when adding or editing.
issue 9: Added missing validation that checked for 'unique_lang' validation in sector
issue 10: Is not an issue. Error was found when testing in dev because the error generated from language branch #885 . Which was merged to dev when testing.
issue 12: Added a '?' at the end of the text instead of '.' .
issue 13: Added OrganisationRegistryAgency prefix : 'XM', to a list of prefixes that are not country dependent. RegistrationAgency with prefix XM are now available for organisations of any country.

[sriza]

issue 5: Not an issue. Might be caused by some setting present in ms excel, works fine with libreoffice calc
Issue 6: Added recipient region, recipient country and sector validation in transaction to error (was previously in warning, thus wasn't being emptied). Emptied them before saving to database.

[PG-Momik]

@DaveEade49 @emmajclegg @siwhitehouse @IsabelBirds

These issues has been resolved and the fixes are now deployed to staging branch. Please have a look and let us know if issue persists.
Thank you.

[DaveEade49]

@PG-Momik - Hi - Can you clarify more about issue 4? I've tried this one in Staging and Live and still get diverted to settings.

[DaveEade49]

@PG-Momik & @sriza - Issue 5 - This is an issue, I think what is happening here is that the "blank" csv that is being populated by the export process as the cells in column CT set to "custom" for dates instead of "general" which would then just render the value as 2 or whatever it is. ( see screenshot )
The problem is that if you change the formatting from custom to general it translates that date value back into a number based on the date value in Excel so you end up with "44928". This does need to be sorted.

[DaveEade49]

Summary of Testing

• 1. Passed
• 2. This seems to work in staging and live ok.
• 3. Passed
• 4. Fail - still an issue
• 5. Fail - see other comments
• 6. Pass
• 7. Pass
• 8. Fail - still an issue, but the user can resolve by scrolling
• 9. Pass
• 10. Pass
• 11. Pass
• 12. Pass
• 13. Don't understand fix response in relation to original bug, also cannot recreate original - not sure where that screen in in which user story.

[praweshsth]

For no. 5, use single or double quote to make it string so that excel doesn't take it as date. - There are two values that this happens to not just one

[PG-Momik]

@DaveEade49 issue 13 was seen in organisation : World Vegetable Center. This organisation had the following information in organisation-identifier:

1. Country: TW - Taiwan
2. Registration Agency : XM-DAC - OECD Development Assisatnce Committee
3. Registration number : 47008
4. Organisation-identifier: XM-DAC-47008

Before the fix, in the organisation-identifier edit page, an organisation could only chose organisation registration agency that had the country prefix (TW in this case) or the prefixes : XI or XR. Since the organisation had Registration Agency with prefix XM, the data was considered invalid and would not be displayed. This was causing the form to flicker on initial load.

[DaveEade49]

@PG-Momik - Ah, ok thats great - I'll mark that one as closed.

[PG-Momik]

Hi @DaveEade49 ,

Regarding issue 5, we've made changes to how Humanitarian Scope Vocabulary in csv are handled. Previously Humanitarian Scope Vocabulary cell would only consist one fo these code:
1-2,
2-1,
99

Now the downloaded csv will contain either one of the follwing :
1-2-Glide
2-1-Humanitarian Plan
99-Reporting Organisation

Similarly when importing csv, any/all of the following data will be considered valid csv data :
1-2-Glide,
2-1-Humanitarian Plan,
99-Reporting Organisation
1-2,
2-1,
99

---

This change has been deployed to staging.

[DaveEade49]

Ok, happy with this fix - can we please apply to production.