@@ -47,7 +47,7 @@ beforeEach(() => {
data-test-id={testId}
checked
/>
-
+
@@ -105,10 +105,7 @@ describe('Detail', () => {
detail.addEvents()
- expect(detail.element.addEventListener).toHaveBeenCalledWith(
- 'click',
- detail.onClickOnElement
- )
+ expect(detail.element.addEventListener).toHaveBeenCalledWith('click', detail.onClickOnElement)
expect(detail.element.addEventListener).toHaveBeenCalledWith(
'change',
detail.onChangeOnElement
@@ -248,7 +245,7 @@ describe('Detail', () => {
action: 'changeVariation',
data: {
testId,
- variationId: parseInt(newVariationId),
+ variationId: Number.parseInt(newVariationId),
cookieValue: `uid=zed18spa36wefrnq&fst=1632216663697&pst=-1&cst=1632216663697&ns=1&pvt=1&pvis=1&th=661111.200001.1.1.1.1.1632216664066.1632216664066.1.2_${testId}.${newVariationId}.1.1.1.1.1632216664068.1632216664068.1.2`
}
})
@@ -277,7 +274,7 @@ describe('Detail', () => {
action: 'changeVariation',
data: {
testId,
- variationId: parseInt(newVariationId),
+ variationId: Number.parseInt(newVariationId),
cookieValue: `uid=zed18spa36wefrnq&fst=1632216663697&pst=-1&cst=1632216663697&ns=1&pvt=1&pvis=1&th=661111.200001.1.1.1.1.1632216664066.1632216664066.1.2_${testId}.${newVariationId}.1.1.1.1.1632216664068.1632216664068.1.2`
}
})
@@ -306,7 +303,7 @@ describe('Detail', () => {
action: 'changeVariation',
data: {
testId,
- variationId: parseInt(newVariationId),
+ variationId: Number.parseInt(newVariationId),
cookieValue: `uid=zed18spa36wefrnq&fst=1632216663697&pst=-1&cst=1632216663697&ns=1&pvt=1&pvis=1&th=661111.200001.1.1.1.1.1632216664066.1632216664066.1.2_${testId}.${newVariationId}.1.1.1.1.1632216664068.1632216664068.1.2`
}
})
diff --git a/src/popup/components/detail/assets/scripts/detail.tsx b/src/popup/components/detail/assets/scripts/detail.tsx
index 6927e58..65437b2 100644
--- a/src/popup/components/detail/assets/scripts/detail.tsx
+++ b/src/popup/components/detail/assets/scripts/detail.tsx
@@ -1,8 +1,8 @@
+import { Component, navigate } from 'costro'
+import type { TargetingsSortedByStatus } from 'shared/assets/definitions/types'
+import { namespace, sendMessage } from 'shared/utils/bridge'
import validateTarget from 'validate-target'
import TemplateDetail from './templates/detail'
-import { Component, navigate } from 'costro'
-import { sendMessage, namespace } from 'shared/utils/bridge'
-import { TargetingsSortedByStatus } from 'shared/assets/definitions/types'
export default class Detail extends Component {
element: null | HTMLElement
@@ -135,7 +135,7 @@ export default class Detail extends Component {
*/
switchVariation(e: Event) {
const target = e.target as HTMLInputElement
- const newVariationId = parseInt(target.value)
+ const newVariationId = Number.parseInt(target.value)
const testId = target.getAttribute('data-test-id') as string
sendMessage({
@@ -148,11 +148,9 @@ export default class Detail extends Component {
const thValue = response.split('&').find((item: string) => item.includes('th='))
if (thValue) {
- const currentVariationId = thValue.match(
- new RegExp(`${testId}.(-?[0-9]*).`)
- )
+ const currentVariationId = thValue.match(new RegExp(`${testId}.(-?[0-9]*).`))
- if (currentVariationId && currentVariationId.length) {
+ if (currentVariationId?.length) {
const thValueUpdated = thValue.replace(
`${testId}.${currentVariationId[1]}`,
`${testId}.${newVariationId}`
diff --git a/src/popup/components/detail/assets/scripts/templates/detail.tsx b/src/popup/components/detail/assets/scripts/templates/detail.tsx
index 9ca15b6..c16a01f 100644
--- a/src/popup/components/detail/assets/scripts/templates/detail.tsx
+++ b/src/popup/components/detail/assets/scripts/templates/detail.tsx
@@ -1,12 +1,12 @@
-import externalLink from 'shared/assets/svgs/external-link.svg'
+import { navigate } from 'costro'
+import type { DetailData, Targeting } from 'shared/assets/definitions/types'
import arrowBottom from 'shared/assets/svgs/arrow-bottom.svg'
import chart from 'shared/assets/svgs/chart.svg'
+import externalLink from 'shared/assets/svgs/external-link.svg'
+import CollapseTemplate from 'shared/collapse/assets/scripts/collapse'
import TargetingTemplate from 'shared/targeting/assets/scripts/targeting'
-import VariationTemplate from 'shared/variation/assets/scripts/variation'
import TrackingTemplate from 'shared/tracking/assets/scripts/tracking'
-import CollapseTemplate from 'shared/collapse/assets/scripts/collapse'
-import { Targeting, DetailData } from 'shared/assets/definitions/types'
-import { navigate } from 'costro'
+import VariationTemplate from 'shared/variation/assets/scripts/variation'
/**
* Detail template
@@ -53,8 +53,8 @@ export default function ({ testId, identifier, test, result, targetingSorted }:
-
-
@@ -63,10 +63,9 @@ export default function ({ testId, identifier, test, result, targetingSorted }:
href={`https://app2.abtasty.com/reporting/test/${testId}/report`}
target="_blank"
rel="noreferrer"
- className="detail-headerReport"
- >
+ className="detail-headerReport">
See the report
-
+
@@ -92,9 +91,8 @@ export default function ({ testId, identifier, test, result, targetingSorted }:
href={`https://app2.abtasty.com/edit/test/${testId}/audience`}
target="_blank"
rel="noreferrer"
- className="detail-subtitleLink"
- >
-
+ className="detail-subtitleLink">
+
{templateTargeting}
diff --git a/src/popup/components/detail/assets/styles/detail.css b/src/popup/components/detail/assets/styles/detail.css
index cfc1091..05e6b37 100644
--- a/src/popup/components/detail/assets/styles/detail.css
+++ b/src/popup/components/detail/assets/styles/detail.css
@@ -1,5 +1,5 @@
.detail {
- padding: 5px 15px 15px;
+ padding: 5px 15px 15px;
&-header {
display: flex;
diff --git a/src/popup/components/list/__tests__/list.test.js b/src/popup/components/list/__tests__/list.test.js
index 1bc8a99..9ece7ce 100644
--- a/src/popup/components/list/__tests__/list.test.js
+++ b/src/popup/components/list/__tests__/list.test.js
@@ -1,5 +1,5 @@
-import validateTarget from 'validate-target'
import { namespace, sendMessage } from 'shared/utils/bridge'
+import validateTarget from 'validate-target'
import List from '../assets/scripts/list'
const testId = '100002'
@@ -35,8 +35,8 @@ beforeEach(() => {